Project

General

Profile

Actions

Bug #82787

closed

Reediting link in ckeditor leads to exception

Added by Christoph Lehmann over 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
-
Target version:
-
Start date:
2017-10-17
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
7.1
Tags:
ckeditor
Complexity:
no-brainer
Is Regression:
Sprint Focus:

Description

htmlspecialchars() expects parameter 1 to be string, null given TypeError thrown in file /usr/local/share/typo3/typo3_src-8.7.8/typo3/sysext/rte_ckeditor/Classes/Controller/BrowseLinksController.php in line 387.

Reproduce:

  • Activate relAttribute in ckeditor configuration with
    buttons:
      link:
        relAttribute:
          enabled: true
    
  • Set a link in ckeditor
  • click on the link button again

Change

        $currentRel = $this->displayedLinkHandler === $this->currentLinkHandler && !empty($this->currentLinkParts)
            ? $this->linkAttributeValues['rel']
            : '';

to

        $currentRel = $this->displayedLinkHandler === $this->currentLinkHandler && !empty($this->currentLinkParts) && !is_null($this->linkAttributeValues['rel'])
            ? $this->linkAttributeValues['rel']
            : '';

in line 376


Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Bug #83137: Editing of links results in an exception when the 'rel' attribute is enabledRejected2017-11-28

Actions
Has duplicate TYPO3 Core - Bug #82963: Editing of links with empty rel attribute causes exception in ckeditorRejected2017-11-10

Actions
Actions #1

Updated by Gerrit Code Review over 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54415

Actions #2

Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54415

Actions #3

Updated by Gerrit Code Review over 6 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54434

Actions #4

Updated by Christoph Lehmann over 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #5

Updated by Frans Saris over 6 years ago

  • Has duplicate Bug #82963: Editing of links with empty rel attribute causes exception in ckeditor added
Actions #6

Updated by Frans Saris over 6 years ago

  • Related to Bug #83137: Editing of links results in an exception when the 'rel' attribute is enabled added
Actions #7

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF