Bug #71686

Image ViewHelper throws excpetion if image is missing

Added by Andreas Allacher almost 6 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Must have
Category:
Fluid
Target version:
Start date:
2015-11-19
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

The image ViewHelper should catch the ResourceDoesNotExist and UnexpectedValueException exception, otherwise the whole page will be unloadable because one image is missing or has the wrong value (e.g. File was replaced with a folder)


Related issues

Related to TYPO3 Core - Bug #45779: Blank page/Exception when referenced images are deleted in filesystemClosed2013-02-23

Actions
Related to TYPO3 Core - Bug #45696: typo3 crashes (with exeption) if a Image is deleted in fileadminClosed2013-02-21

Actions
Related to TYPO3 Core - Bug #61861: Frontend throws exception on missing imageClosed2014-09-24

Actions
Related to TYPO3 Core - Bug #82918: Do not silently ignore exceptions in image viewhelperClosedSascha Egerer2017-11-03

Actions
Has duplicate TYPO3 Core - Bug #72042: Backport Catching of Exception in ImageViewhelper to 6.2.XClosed2015-12-03

Actions
#1

Updated by Gerrit Code Review almost 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44796

#2

Updated by Riccardo De Contardi almost 6 years ago

Is it the same as #45696 ?

#3

Updated by Andreas Allacher almost 6 years ago

I am not sure where the issue happens in #45696 ?
If I delete the file and browse to it in fileadmin?

This is only a change in fluid, so if the image is accessed via fluid then yes, otherwise not.

#4

Updated by Thomas Sperling almost 6 years ago

I think there should be some kind of logging if the file is missing.

#5

Updated by Riccardo De Contardi almost 6 years ago

I'm not sure, but I think that #45696 refers to frontend

#6

Updated by Gerrit Code Review almost 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44796

#7

Updated by Gerrit Code Review almost 6 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45122

#8

Updated by Anonymous almost 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#9

Updated by Gerrit Code Review almost 6 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45123

#10

Updated by Gerrit Code Review almost 6 years ago

Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45122

#11

Updated by Gerrit Code Review almost 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45123

#12

Updated by Gerrit Code Review almost 6 years ago

Patch set 3 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45122

#13

Updated by Benni Mack almost 6 years ago

  • Status changed from Under Review to Resolved
#14

Updated by Clemens Riccabona almost 6 years ago

Hmm, silently catching the exception, and doing nothing ... is this supposed to be a solution, or just a hack? ;)

maybe we should consider also for 6.2 the solution used upstream:

https://review.typo3.org/#/c/40212/6/typo3/sysext/fluid/Classes/Core/ViewHelper/AbstractViewHelper.php

#15

Updated by Christiaan Wiesenekker almost 6 years ago

I think this should also be fixed for at least 6.2 LTS? Target 7.6.1?? If you have multiple sites and you want to update them all this will be released in 2018.

Like to hear your thoughts about this.

#16

Updated by Gerrit Code Review almost 6 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45166

#17

Updated by Gerrit Code Review almost 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45166

#18

Updated by Anonymous almost 6 years ago

  • Status changed from Under Review to Resolved
#19

Updated by Gerrit Code Review almost 6 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45169

#20

Updated by Gerrit Code Review almost 6 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45170

#21

Updated by Gerrit Code Review almost 6 years ago

Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45170

#22

Updated by Anonymous almost 6 years ago

  • Status changed from Under Review to Resolved
#23

Updated by Andreas Allacher almost 6 years ago

@Christiaan Wiesenekker:
Please see applied patchsets for this ticket, the bugfix has also been backported and merged for 6.2, so it will be included in the next 6.2 release.

#24

Updated by Tizian Schmidlin almost 6 years ago

The bugfix ist not yet included in the current TYPO3 version 6.2.16

#25

Updated by Andreas Allacher almost 6 years ago

It is includeded. I checked the source code of the .zip file.
However the change only affects f:image and f:uri.image Viewhelpers.
It is still possible that other cases e.g. custom Viewhelpers or extensions (or other parts of the core) have that issue.

#26

Updated by Riccardo De Contardi almost 4 years ago

  • Status changed from Resolved to Closed
#27

Updated by Frans Saris almost 4 years ago

  • Related to Bug #82918: Do not silently ignore exceptions in image viewhelper added

Also available in: Atom PDF