Bug #71686
closed
Image ViewHelper throws excpetion if image is missing
100%
Description
The image ViewHelper should catch the ResourceDoesNotExist and UnexpectedValueException exception, otherwise the whole page will be unloadable because one image is missing or has the wrong value (e.g. File was replaced with a folder)
Updated by Gerrit Code Review about 9 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44796
Updated by Andreas Allacher about 9 years ago
I am not sure where the issue happens in #45696 ?
If I delete the file and browse to it in fileadmin?
This is only a change in fluid, so if the image is accessed via fluid then yes, otherwise not.
Updated by Thomas Sperling about 9 years ago
I think there should be some kind of logging if the file is missing.
Updated by Riccardo De Contardi about 9 years ago
I'm not sure, but I think that #45696 refers to frontend
Updated by Gerrit Code Review about 9 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44796
Updated by Gerrit Code Review almost 9 years ago
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45122
Updated by Anonymous almost 9 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 73e1ca96f069e9840066346731092461a119b8bf.
Updated by Gerrit Code Review almost 9 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45123
Updated by Gerrit Code Review almost 9 years ago
Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45122
Updated by Gerrit Code Review almost 9 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45123
Updated by Gerrit Code Review almost 9 years ago
Patch set 3 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45122
Updated by Benni Mack almost 9 years ago
- Status changed from Under Review to Resolved
Applied in changeset f992c575f029c151d29b96fd696ed42caec49bef.
Updated by Clemens Riccabona almost 9 years ago
Hmm, silently catching the exception, and doing nothing ... is this supposed to be a solution, or just a hack? ;)
maybe we should consider also for 6.2 the solution used upstream:
Updated by Christiaan Wiesenekker almost 9 years ago
I think this should also be fixed for at least 6.2 LTS? Target 7.6.1?? If you have multiple sites and you want to update them all this will be released in 2018.
Like to hear your thoughts about this.
Updated by Gerrit Code Review almost 9 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45166
Updated by Gerrit Code Review almost 9 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45166
Updated by Anonymous almost 9 years ago
- Status changed from Under Review to Resolved
Applied in changeset d83379058148479d33be2e1853a8995a56cfad15.
Updated by Gerrit Code Review almost 9 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45169
Updated by Gerrit Code Review almost 9 years ago
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45170
Updated by Gerrit Code Review almost 9 years ago
Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45170
Updated by Anonymous almost 9 years ago
- Status changed from Under Review to Resolved
Applied in changeset 519a461495f4c3c2d53688a9ad81d10d2cd87c79.
Updated by Andreas Allacher almost 9 years ago
@Christiaan Wiesenekker:
Please see applied patchsets for this ticket, the bugfix has also been backported and merged for 6.2, so it will be included in the next 6.2 release.
Updated by Tizian Schmidlin almost 9 years ago
The bugfix ist not yet included in the current TYPO3 version 6.2.16
Updated by Andreas Allacher almost 9 years ago
It is includeded. I checked the source code of the .zip file.
However the change only affects f:image and f:uri.image Viewhelpers.
It is still possible that other cases e.g. custom Viewhelpers or extensions (or other parts of the core) have that issue.
Updated by Riccardo De Contardi about 7 years ago
- Status changed from Resolved to Closed
Updated by Frans Saris about 7 years ago
- Related to Bug #82918: Do not silently ignore exceptions in image viewhelper added
Updated by Nikita Hovratov about 1 year ago
- Related to Task #102223: Remove dead catch in ImageViewHelper added