Project

General

Profile

Actions

Bug #71686

closed

Image ViewHelper throws excpetion if image is missing

Added by Andreas Allacher over 8 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Must have
Category:
Fluid
Target version:
Start date:
2015-11-19
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

The image ViewHelper should catch the ResourceDoesNotExist and UnexpectedValueException exception, otherwise the whole page will be unloadable because one image is missing or has the wrong value (e.g. File was replaced with a folder)


Related issues 6 (0 open6 closed)

Related to TYPO3 Core - Bug #45779: Blank page/Exception when referenced images are deleted in filesystemClosed2013-02-23

Actions
Related to TYPO3 Core - Bug #45696: typo3 crashes (with exeption) if a Image is deleted in fileadminClosed2013-02-21

Actions
Related to TYPO3 Core - Bug #61861: Frontend throws exception on missing imageClosed2014-09-24

Actions
Related to TYPO3 Core - Bug #82918: Do not silently ignore exceptions in image viewhelperClosedSascha Egerer2017-11-03

Actions
Related to TYPO3 Core - Task #102223: Remove dead catch in ImageViewHelperClosed2023-10-22

Actions
Has duplicate TYPO3 Core - Bug #72042: Backport Catching of Exception in ImageViewhelper to 6.2.XClosed2015-12-03

Actions
Actions #1

Updated by Gerrit Code Review over 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44796

Actions #2

Updated by Riccardo De Contardi over 8 years ago

Is it the same as #45696 ?

Actions #3

Updated by Andreas Allacher over 8 years ago

I am not sure where the issue happens in #45696 ?
If I delete the file and browse to it in fileadmin?

This is only a change in fluid, so if the image is accessed via fluid then yes, otherwise not.

Actions #4

Updated by Thomas Sperling over 8 years ago

I think there should be some kind of logging if the file is missing.

Actions #5

Updated by Riccardo De Contardi over 8 years ago

I'm not sure, but I think that #45696 refers to frontend

Actions #6

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44796

Actions #7

Updated by Gerrit Code Review over 8 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45122

Actions #8

Updated by Anonymous over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #9

Updated by Gerrit Code Review over 8 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45123

Actions #10

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45122

Actions #11

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45123

Actions #12

Updated by Gerrit Code Review over 8 years ago

Patch set 3 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45122

Actions #13

Updated by Benni Mack over 8 years ago

  • Status changed from Under Review to Resolved
Actions #14

Updated by Clemens Riccabona over 8 years ago

Hmm, silently catching the exception, and doing nothing ... is this supposed to be a solution, or just a hack? ;)

maybe we should consider also for 6.2 the solution used upstream:

https://review.typo3.org/#/c/40212/6/typo3/sysext/fluid/Classes/Core/ViewHelper/AbstractViewHelper.php

Actions #15

Updated by Christiaan Wiesenekker over 8 years ago

I think this should also be fixed for at least 6.2 LTS? Target 7.6.1?? If you have multiple sites and you want to update them all this will be released in 2018.

Like to hear your thoughts about this.

Actions #16

Updated by Gerrit Code Review over 8 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45166

Actions #17

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45166

Actions #18

Updated by Anonymous over 8 years ago

  • Status changed from Under Review to Resolved
Actions #19

Updated by Gerrit Code Review over 8 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45169

Actions #20

Updated by Gerrit Code Review over 8 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45170

Actions #21

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45170

Actions #22

Updated by Anonymous over 8 years ago

  • Status changed from Under Review to Resolved
Actions #23

Updated by Andreas Allacher over 8 years ago

@Christiaan Wiesenekker:
Please see applied patchsets for this ticket, the bugfix has also been backported and merged for 6.2, so it will be included in the next 6.2 release.

Actions #24

Updated by Tizian Schmidlin over 8 years ago

The bugfix ist not yet included in the current TYPO3 version 6.2.16

Actions #25

Updated by Andreas Allacher over 8 years ago

It is includeded. I checked the source code of the .zip file.
However the change only affects f:image and f:uri.image Viewhelpers.
It is still possible that other cases e.g. custom Viewhelpers or extensions (or other parts of the core) have that issue.

Actions #26

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions #27

Updated by Frans Saris over 6 years ago

  • Related to Bug #82918: Do not silently ignore exceptions in image viewhelper added
Actions #28

Updated by Nikita Hovratov 9 months ago

  • Related to Task #102223: Remove dead catch in ImageViewHelper added
Actions

Also available in: Atom PDF