Task #82975

Deprecate usage of @inject with non-public properties

Added by Alexander Schnitzler about 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Category:
Extbase
Target version:
Start date:
2017-11-11
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

When using private or protected properties for Dependency Injection, Extbase needs to use the object reflection API to make these properties settable from the outside, which is quite slow and cannot be cached in any way.
Therefore property injection should only work for public properties.

Associated revisions

Revision 83155a80 (diff)
Added by Alexander Schnitzler about 2 years ago

[TASK] Deprecate usage of @inject with non-public properties

When using private or protected properties for Dependency Injection
via `@inject`, Extbase needs to use the object reflection API to
make these properties settable from the outside, which is quite
slow and cannot be cached in any way. Therefore property injection
should only work for public properties.

Releases: master
Resolves: #82975
Change-Id: Ia9c6eb48c34c46634e626f7cd97a2e743a6aba7b
Reviewed-on: https://review.typo3.org/54618
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>
Tested-by: TYPO3com <>
Reviewed-by: Stefan Neufeind <>
Tested-by: Stefan Neufeind <>

History

#1 Updated by Gerrit Code Review about 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54618

#2 Updated by Gerrit Code Review about 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54618

#3 Updated by Gerrit Code Review about 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54618

#4 Updated by Gerrit Code Review about 2 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54618

#5 Updated by Gerrit Code Review about 2 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54618

#6 Updated by Gerrit Code Review about 2 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54618

#7 Updated by Anonymous about 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#8 Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF