Bug #83090

Save and close on file editing (from filelist) doesn't close

Added by Tymoteusz Motylewski over 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2017-11-24
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

If you edit a text file from within FileList, and use "save and close" you will not be redirected back to list.

The issue doesn't exist in v8.7

in v8 the hidden fields looked like:

<input type="hidden" name="file[editfile][0][target]" value="57">
<input type="hidden" name="redirect" value="/typo3/index.php?route=%2Ffile%2Feditcontent&.....">

While in v9 we have:
<input type="hidden" name="data[editfile][0][target]" value="57">
<input type="hidden" name="data[editfile][0][redirect]" value="/typo3/index.php?route=%2Ffile%2Feditcontent&...">

^^note the difference in redirect field name

There are 2 possible solutions:
1) change the form generation code to make redirect field have name "redirect"
2) change save&close button js code from
'document.editform.redirect.value='...

to

'document.editform.elements.namedItem("data[editfile][0][redirect]").value='...


Related issues

Related to TYPO3 Core - Bug #81763: Migrate file edit form to FormEngineClosedAndreas Fernandez2017-07-01

Actions
#1

Updated by Tymoteusz Motylewski over 3 years ago

  • Description updated (diff)
#2

Updated by Gerrit Code Review over 3 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54757

#3

Updated by Tymoteusz Motylewski over 3 years ago

  • Related to Bug #81763: Migrate file edit form to FormEngine added
#4

Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54757

#5

Updated by Gerrit Code Review over 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54757

#6

Updated by Tymoteusz Motylewski over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#7

Updated by Benni Mack over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF