Bug #83660
closedEpic #83652: EXT: Redirects module - Umbrella issue
Client-Side Validation of Source Path broken when regex is used
100%
Description
Source Path JS validation contains a few problems and a major bug:
- if using regex the validation destroys an entered regex (removes for example questionmarks and asterisks)
- manually transforming special characters to their translit equivalent is implemented on our own instead of using a library (will currently only work with German umlauts)
Ideally we would have
- client and server side validation working the same way
- validation has to differentiate between regex and non-regex mode
- in case translit behaviour is wanted we should use a library --> but in general why should we change users path segments in that way, having umlauts / a lot of special chars in an url might be totally valid
Updated by Susanne Moog about 7 years ago
- Category set to Site Handling, Site Sets & Routing
Updated by Frank Nägler about 7 years ago
another problem here: in case of a regexp, it could be useful to use other chars than /
as delimiter, e,g, +foo/bar/+g
instead of /foo\/bar\//g
the first one is much easier to read but could not be used now, because the / is added as first and last character all the time.
I would opt for remove the validation here, because nearly every input could be valid. or add the / only if checkbox "is_regexp" is not set.
Updated by Frank Nägler about 7 years ago
- Status changed from New to In Progress
- Assignee set to Frank Nägler
Updated by Gerrit Code Review about 7 years ago
- Status changed from In Progress to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55460
Updated by Frank Nägler about 7 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset f96defdeeddc4ce66d1d327a1eb233a8d18bae06.