Project

General

Profile

Actions

Bug #83660

closed

Epic #83652: EXT: Redirects module - Umbrella issue

Client-Side Validation of Source Path broken when regex is used

Added by Susanne Moog about 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Link Handling, Site Handling & Routing
Target version:
Start date:
2018-01-23
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Source Path JS validation contains a few problems and a major bug:

- if using regex the validation destroys an entered regex (removes for example questionmarks and asterisks)
- manually transforming special characters to their translit equivalent is implemented on our own instead of using a library (will currently only work with German umlauts)

Ideally we would have
- client and server side validation working the same way
- validation has to differentiate between regex and non-regex mode
- in case translit behaviour is wanted we should use a library --> but in general why should we change users path segments in that way, having umlauts / a lot of special chars in an url might be totally valid

Actions #1

Updated by Susanne Moog about 6 years ago

  • Category set to Link Handling, Site Handling & Routing
Actions #2

Updated by Oliver Hader about 6 years ago

  • Target version set to 9.1
Actions #3

Updated by Frank Nägler about 6 years ago

another problem here: in case of a regexp, it could be useful to use other chars than / as delimiter, e,g, +foo/bar/+g instead of /foo\/bar\//g the first one is much easier to read but could not be used now, because the / is added as first and last character all the time.
I would opt for remove the validation here, because nearly every input could be valid. or add the / only if checkbox "is_regexp" is not set.

Actions #4

Updated by Frank Nägler about 6 years ago

  • Status changed from New to In Progress
  • Assignee set to Frank Nägler
Actions #5

Updated by Gerrit Code Review about 6 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55460

Actions #6

Updated by Frank Nägler about 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF