Bug #83720
closed
Wrong page type when translating page through localization overview
100%
Description
When mass-translating multiple pages in Info -> Localization Overview, all pages have the same page type (doktype) set to "standard".
Steps to reproduce:
Given you have untranslated shortcut page "A".
1. go to Info module
2. switch to localization overview
3. select checkbox by the "A" page
4. click on the icon with plus sign from the column header "create new translation headers"
5. fill the titles
6. save & close
You will see that newly created page translation will have wrong page type = standard instead of shortcut
Updated by Tymoteusz Motylewski almost 7 years ago
The issue is present in v7 also.
Unfortunatelly It's not that easy to solve at first sight because EditDocumentController.php expects default values (overrideVals) to be global (same value for all edited records). It's not possible to pass different doctype for each new record.
The query sent by clicking on the "create new translation headers" icons passes following parameters:
route:/record/edit edit[pages_language_overlay][5]:new edit[pages_language_overlay][9]:new overrideVals[pages_language_overlay][sys_language_uid]:1 columnsOnly:title,hidden,sys_language_uid returnUrl:/typo3/index.php?M=web_info&moduleToken=0c38bb5cabfab80ba8350eff44dd8fc971276ecb&id=5&SET[depth]=1
I've compared it to the call sent when translating single page from within page module (which sets doktype correctly):
route:/record/edit edit[pages_language_overlay][5]:new overrideVals[pages_language_overlay][doktype]:4 overrideVals[pages_language_overlay][sys_language_uid]:1 returnUrl:/typo3/index.php?M=web_layout&moduleToken=43726e35b7b6d042911fe3704ad4117c0c2ae9a0&id=5
see additional param "overrideVals[pages_language_overlay][doktype]:4".
The problem is that the overrideVals is global for all records passed to the edit controller.
Updated by Tymoteusz Motylewski almost 7 years ago
one more thing to add is that the list module (when translating tt_content) is doing it differently (calling 'localize' instead of 'new' datahandler command)
route:/record/commit token:ad2e597af4b055d0400169b63d8ead687ed1eb8a prErr:1 uPT:1 cmd[tt_content][11][localize]:1 redirect:/typo3/index.php?M=web_list&moduleToken=318cc442678e966034b8bf1a856e66476ac798c2&id=35&table=tt_content&imagemode=1&justLocalized=tt_content%3A11%3A1
M:web_list moduleToken:318cc442678e966034b8bf1a856e66476ac798c2 id:35 table:tt_content imagemode:1 justLocalized:tt_content:11:1
route:/record/edit token:71ffe7bef130a0b40edd53facdb2f663127a5136 edit[tt_content][207]:edit returnUrl:/typo3/index.php?M=web_list&moduleToken=318cc442678e966034b8bf1a856e66476ac798c2&id=35&table=tt_content&imagemode=1
Updated by
Updated by Gerrit Code Review almost 5 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62874
Updated by Susanne Moog almost 5 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 18ed013f534cfc23c75e825606ba2b3d4fdeb449.
Updated by Gerrit Code Review almost 5 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62882
Updated by Susanne Moog almost 5 years ago
- Status changed from Under Review to Resolved
Applied in changeset f6bc1240bf952302b9edb603caf0d1cbf7caf2e0.
Updated by