Bug #83740
closedCleanup of AbstractRecordList breaks hook
100%
Description
With #82334 the abstract parent class was removed.
This patch has some bad side effect:
1) In all three changed classes the same hook $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS'][DatabaseRecordList::class]['buildQueryParameters'] is used
2) the sixth parameter ($this) refer to one of this three classes, alle three classes has no common abstract parent class nor a common interface
The result: I have no change to write clean code, because I can't add a type hint for the buildQueryParametersPostProcess method.
Beside this points, it is no good idea to use the same hook in different places with different method signatures.
Currently I would opt for an interface, the other solution would ne to revert the original patch.
Updated by Frank Nägler almost 7 years ago
- Related to Story #82334: Refactor AbstractRecordList added
Updated by Frank Nägler almost 7 years ago
- Status changed from New to In Progress
- Assignee set to Frank Nägler
Updated by Gerrit Code Review almost 7 years ago
- Status changed from In Progress to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55512
Updated by Gerrit Code Review almost 7 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55512
Updated by Gerrit Code Review almost 7 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55512
Updated by Gerrit Code Review almost 7 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55512
Updated by Gerrit Code Review almost 7 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55512
Updated by Gerrit Code Review almost 7 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55512
Updated by Frank Nägler almost 7 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 4f17dd08dc4da005922b576796c43c1a5be88945.