Project

General

Profile

Actions

Bug #83740

closed

Cleanup of AbstractRecordList breaks hook

Added by Frank Nägler about 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
-
Target version:
-
Start date:
2018-01-31
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

With #82334 the abstract parent class was removed.

This patch has some bad side effect:

1) In all three changed classes the same hook $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS'][DatabaseRecordList::class]['buildQueryParameters'] is used
2) the sixth parameter ($this) refer to one of this three classes, alle three classes has no common abstract parent class nor a common interface

The result: I have no change to write clean code, because I can't add a type hint for the buildQueryParametersPostProcess method.
Beside this points, it is no good idea to use the same hook in different places with different method signatures.

Currently I would opt for an interface, the other solution would ne to revert the original patch.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Story #82334: Refactor AbstractRecordListClosedSimon Praetorius2017-09-07

Actions
Actions

Also available in: Atom PDF