Task #83889

Task #83888: Notice free unit tests

Handle E_NOTICE free unit tests

Added by Christian Kuhn over 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2018-02-13
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

The main patch raises typo3/testing-framework to 3.0.0 which comes with a version that no longer suppresses E_NOTICE PHP errors by default and lets tests fail that raises them.

The static property $suppressNotices in unit test files is set to true for all test cases that currently raise E_NOTICE errors to suppress them on a by-file basis.

Following patches should remove this property one-by-one again by fixing the system under test the unit test case handles.


Related issues

Related to TYPO3 Core - Epic #84280: Make unit tests notice free Closed 2018-03-15

Associated revisions

Revision e514f439 (diff)
Added by Christian Kuhn over 1 year ago

[!!!][TASK] Handle E_NOTICE free unit tests

Raise typo3/testing-framework from 2.0.4 to 3.0.0:
composer require --dev typo3/testing-framework ^3.0

The new typo3/testing-framework version comes with a change
that no longer suppresses E_NOTICE PHP errors by default and lets
tests fail that raise them.

The static property $suppressNotices in unit test files is set to
true for all test cases that currently raise E_NOTICE errors to
suppress them on a by-file basis.

Further patches should remove this property one-by-one again by
fixing the system under test the unit test case handles.

Change-Id: I7d44fe3723ce5820a37051ae31f16b2f142ffba6
Resolves: #83889
Related: #83888
Releases: master
Reviewed-on: https://review.typo3.org/55697
Reviewed-by: Tymoteusz Motylewski <>
Tested-by: Tymoteusz Motylewski <>
Tested-by: TYPO3com <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

History

#1 Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55697

#2 Updated by Gerrit Code Review over 1 year ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55697

#3 Updated by Gerrit Code Review over 1 year ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55697

#4 Updated by Gerrit Code Review over 1 year ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55697

#5 Updated by Christian Kuhn over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Christian Kuhn over 1 year ago

  • Related to Epic #84280: Make unit tests notice free added

#7 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF