Bug #83971

Console show deprecation warning in chrome

Added by Frank Naegler over 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Backend JavaScript
Target version:
Start date:
2018-02-20
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

[Deprecation] The Notification API may no longer be used from insecure origins. You should consider switching your application to a secure origin, such as HTTPS. See https://goo.gl/rStTGz for more details.

The LoginRefresh.js contains this code:

if (typeof Notification !== 'undefined' && Notification.permission !== 'granted') {
      Notification.requestPermission();
}

this code should only be executed on SSL protected sides to prevent the deprecation warning


Related issues

Related to TYPO3 Core - Task #84086: Notification change for chrome is Important, not Breaking Closed 2018-02-28

Associated revisions

Revision eab35317 (diff)
Added by Frank Naegler over 1 year ago

[!!!][BUGFIX] Allow browser notifications only on encrypted connection

Google Chrome deprecated the browser notification API for unencrypted
origins. For this reason we now use an additional check to prevent
deprecation warnings in the console and disable this feature for
instances without SSL/TLS.

Resolves: #83971
Releases: master, 8.7
Change-Id: I9721842159e7ad3da9e5f4ee93a9bce3eaf5d0eb
Reviewed-on: https://review.typo3.org/55916
Tested-by: TYPO3com <>
Reviewed-by: Georg Ringer <>
Tested-by: Georg Ringer <>
Reviewed-by: Sascha Egerer <>
Tested-by: Sascha Egerer <>
Reviewed-by: Josef Glatz <>
Tested-by: Josef Glatz <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

Revision 8acdac43 (diff)
Added by Christian Kuhn over 1 year ago

[TASK] Notification change for chrome is Important, not Breaking

Patch for issue #83971 is only an Important change, not
a breaking change and belongs to the 8.7.x documentation
folder to stay in sync with v8

Change-Id: I1314eda5dbf90af5e61b940ad1431b82bd28b0de
Resolves: #84086
Related: #83971
Releases: master
Reviewed-on: https://review.typo3.org/55945
Reviewed-by: Frank Naegler <>
Tested-by: Frank Naegler <>
Tested-by: TYPO3com <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

Revision 4820410d (diff)
Added by Frank Naegler over 1 year ago

[BUGFIX] Allow browser notifications only on encrypted connection

Google Chrome deprecated the browser notification API for unencrypted
origins. For this reason we now use an additional check to prevent
deprecation warnings in the console and disable this feature for
instances without SSL/TLS.

Resolves: #83971
Releases: master, 8.7
Change-Id: I9721842159e7ad3da9e5f4ee93a9bce3eaf5d0eb
Reviewed-on: https://review.typo3.org/55946
Reviewed-by: Frank Naegler <>
Tested-by: TYPO3com <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

History

#1 Updated by Andreas Fernandez over 1 year ago

We have to check how other browsers handle this. Simply checking for HTTPS could break that feature for non-affected browsers.

#2 Updated by Frank Naegler over 1 year ago

  • Status changed from New to In Progress
  • Assignee set to Frank Naegler

#3 Updated by Gerrit Code Review over 1 year ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55916

#4 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55916

#5 Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55916

#6 Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55916

#7 Updated by Gerrit Code Review over 1 year ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55916

#8 Updated by Gerrit Code Review over 1 year ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55916

#9 Updated by Frank Naegler over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#10 Updated by Christian Kuhn over 1 year ago

  • Related to Task #84086: Notification change for chrome is Important, not Breaking added

#11 Updated by Gerrit Code Review over 1 year ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55946

#12 Updated by Frank Naegler over 1 year ago

  • Status changed from Under Review to Resolved

#13 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF