Bug #83971

Console show deprecation warning in chrome

Added by Frank Naegler almost 4 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Backend JavaScript
Target version:
Start date:
2018-02-20
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

[Deprecation] The Notification API may no longer be used from insecure origins. You should consider switching your application to a secure origin, such as HTTPS. See https://goo.gl/rStTGz for more details.

The LoginRefresh.js contains this code:

if (typeof Notification !== 'undefined' && Notification.permission !== 'granted') {
      Notification.requestPermission();
}

this code should only be executed on SSL protected sides to prevent the deprecation warning


Related issues

Related to TYPO3 Core - Task #84086: Notification change for chrome is Important, not BreakingClosed2018-02-28

Actions
#1

Updated by Andreas Fernandez almost 4 years ago

We have to check how other browsers handle this. Simply checking for HTTPS could break that feature for non-affected browsers.

#2

Updated by Frank Naegler almost 4 years ago

  • Status changed from New to In Progress
  • Assignee set to Frank Naegler
#3

Updated by Gerrit Code Review almost 4 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55916

#4

Updated by Gerrit Code Review almost 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55916

#5

Updated by Gerrit Code Review almost 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55916

#6

Updated by Gerrit Code Review almost 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55916

#7

Updated by Gerrit Code Review almost 4 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55916

#8

Updated by Gerrit Code Review almost 4 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55916

#9

Updated by Frank Naegler almost 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#10

Updated by Christian Kuhn almost 4 years ago

  • Related to Task #84086: Notification change for chrome is Important, not Breaking added
#11

Updated by Gerrit Code Review almost 4 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55946

#12

Updated by Frank Naegler almost 4 years ago

  • Status changed from Under Review to Resolved
#13

Updated by Benni Mack about 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF