Project

General

Profile

Actions
Copy link

Bug #84018

closed

TYPO3 pagetree: default page icon not shown

Added by Josef Glatz over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Pagetree
Target version:
-
Start date:
2018-02-23
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Problem/Description

The default page doktype icon isn't shown within in the TYPO3 pagetree

The corresponding symbol is shown in top of the pagetree (drag-n-drop source for new pages)

so, I think the svg icon itself isn't broken.

Steps to reproduce

- set up actual T3 master (9, 2018-02-22)
- Add a new page (default dokType)
- → no page icon is shown
- Add a new page (sysfolder dokType)
- → sysfolder page icon is shown

EDIT 2018-02-26: 3 days later and the same browser session:

  • Reload backend
  • enter be login credentials
  • page icon is here
  • häää?

Files

image.png (4.31 KB) image.png Josef Glatz, 2018-02-23 07:36
Actions
Copy link
 #1

Updated by Josef Glatz over 6 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Josef Glatz over 6 years ago

  • Description updated (diff)
Actions
Copy link
 #3

Updated by Gerrit Code Review over 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55904

Actions
Copy link
 #4

Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55904

Actions
Copy link
 #5

Updated by Gerrit Code Review over 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55904

Actions
Copy link
 #6

Updated by Tymoteusz Motylewski over 6 years ago

can be tested also by looking into the source of the tree <defs> node, to observe that without the patch, on every expand/collapse of nodes the there are duplicated icons (children of <defs>)

Actions
Copy link
 #7

Updated by Josef Glatz over 6 years ago

Reproduce the missing page-default icon problem race-condition sometimes with

- Chrome
- DevTools open
- Cache disabled in DevTools
- No network throttling
- multiple times "CMD+SHIFT+R"
- hold on: both XHR request for the `*page-default` works and responds ccorrectly with Status 200. The first one with HTML markup and "inline" svg tag. The 2nd one also with HTML markup and a img tag with the svg path in src-attribute.
- no error/warning in console

I have an success rate of about 1 of 10 times

Actions
Copy link
 #8

Updated by Paweł Rogowicz over 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #9

Updated by Gerrit Code Review over 6 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56114

Actions
Copy link
 #10

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Under Review to Closed

I close this for now, as the patch has been merged on Master and the backport to version 8.7 has been abandoned (see https://review.typo3.org/56114).

If you think that this is the wrong decision, please reopen it or ping me and I'll do.

Thank you

Actions
Copy link

Also available in: Atom PDF