Bug #84178

Cannot create but upload file with "@" in name

Added by Mathias Brodala over 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
File Abstraction Layer (FAL)
Target version:
Start date:
2018-03-08
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

In FAL there are at least two different ways to create files which apparently do not apply the same sanitation/validation rules to file names.

This can be verified easily in the Filelist module: if you try to upload a file called everything simply works.

But if you create a file called a ResourceDoesNotExistException is thrown:

#1329647780: Object with identifier "1:/foo@bar.txt" does not exist in storage

When opening the file list once more after this, an error flash message is shown which says File name "" was not allowed!.

This behavior can be traced back to these two code paths:

  • LocalDriver::addFile() calls LocalDriver::sanitizeFileName() which accepts (this is used e.g. for file uploads)
  • LocalDriver::createFile() calls AbstractDriver::isValidFilename() which denies (this is used for everything else)

Related issues

Related to TYPO3 Core - Bug #84079: Error after creating file containing spacesClosed2018-02-28

Actions
#1

Updated by Gerrit Code Review over 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56089

#2

Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56089

#3

Updated by Wolfgang Klinger over 3 years ago

  • Related to Bug #84079: Error after creating file containing spaces added
#4

Updated by Gerrit Code Review over 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56089

#5

Updated by Gerrit Code Review over 3 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56089

#6

Updated by Gerrit Code Review about 3 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56089

#7

Updated by Gerrit Code Review about 3 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56352

#8

Updated by Wolfgang Klinger about 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#9

Updated by Benni Mack over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF