Bug #84266
closedDatabaseRecordLinkBuilder doesn't unset $conf['parameter']
0%
Description
According to documentation, I should be able to configure the recordLink handler as follows:
config.recordLinks { tx_news { typolink { parameter = {$PID.newsPage} additionalParams.data = field:uid additionalParams.wrap = &id={$PID.newsPage}&tx_news_pi1[controller]=News&tx_news_pi1[action]=detail&tx_news_pi1[news]=| useCacheHash = 1 ATagParams.data = parameters:allParams target.data = parameters:target title.data = parameters:title extTarget = _blank extTarget.override.data = parameters:target } forceLink = 1 } }
This doesn't work since DatabaseRecordLinkBuilder also creates a parameter element in its config which, when merged with above configuration results in a parameter value that is an array instead of a string (which would be expected by typoLink).
In order to solve this, something has already been done in on line 64 by unsetting $conf['parameter.']. When unsetting $conf['parameter'] everything seems to be fine (I'll attach a patch file later).
Feel free to ask if anything is unclear.
Best Regards
Tizian
Files
Updated by Tymoteusz Motylewski over 6 years ago
Hi Tizian,
1.Can you please add a steps how can I reproduce the issue?
2. Does this issue occurs with TYPO3 v8 or v9 too?
3. can you push the patch to our review system - https://review.typo3.org
please see documentation on how to contribute https://docs.typo3.org/typo3cms/ContributionWorkflowGuide/WorkflowExplained/Index.html
If you have any issues, just let me know here or on https://typo3.slack.com channel #typo3-cms-coredev
Updated by Tizian Schmidlin over 6 years ago
Hi,
as stated in the ticket information, this happens with TYPO3 8.
The issue is reproducible like this:
- install news
- configure as stated in TYPO3 documentation for record links
- add above typoscript for rendering
Any link that is set to be resolved from <f:link.typolink>
will fail with an exception.
I'll push my change to gerrit asap.
Updated by Gerrit Code Review over 6 years ago
- Status changed from New to Under Review
Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56435
Updated by Gerrit Code Review over 6 years ago
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56436
Updated by Gerrit Code Review over 6 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56436
Updated by Susanne Moog over 6 years ago
- Is duplicate of Bug #84116: Linkhandler links not rendered in frontend when TSConfig configuration is applied using "registerPageTSConfigFile()" or "addPageTSConfig()" added
Updated by Susanne Moog over 6 years ago
- Status changed from Under Review to Closed
This was solved 8 weeks ago via https://review.typo3.org/#/c/56152/ | https://forge.typo3.org/issues/84116
Updated by Tizian Schmidlin over 6 years ago
Hello Susie,
thanks for your feedback, happy to see that this was already fixed when I posted it :-)
The new slogan of the T3 Core team should be "TYPO3, we solve issues you've found before you report them!"
Thanks
Regards
Tizian