Task #84353

Epic #84272: Use PSR-7 ServerRequestInterface in backend controllers

Decouple TreeController from UserSettingsController

Added by Saskia Schreiber over 1 year ago. Updated 11 months ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2018-03-16
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
easy
Sprint Focus:
On Location Sprint

Related issues

Blocks TYPO3 Core - Task #84369: Use ServerRequestInterface in UserSettingsController Closed 2018-03-16

Associated revisions

Revision 6c2fe86e (diff)
Added by Saskia Schreiber over 1 year ago

[TASK] Decouple TreeController from UserSettingsController

Introduce a general wrapper for backend user configuration.

Resolves: #84353
Releases: master
Change-Id: Iddf01a18527ea732dc1c857e153880af57a492fd
Reviewed-on: https://review.typo3.org/56239
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>
Tested-by: TYPO3com <>
Reviewed-by: Andreas Wolf <>
Tested-by: Andreas Wolf <>

History

#1 Updated by Saskia Schreiber over 1 year ago

  • Status changed from New to In Progress

#2 Updated by Saskia Schreiber over 1 year ago

  • Subject changed from Use ServerRequestInterface in UserSettingsController to Refactor UserSettingsController to use a separate registry for user settings

The class UserSettingsController is currently a mixture of an ajax entry point and a registry for user related settings.

It provides an additional public method process() which is used inside the TreeController (to check for expanded pages).
This should be avoided as controllers should only provide proper actions as entry points.

Therefore there should be another class providing the settings for both UserSettingsController and TreeController.

#3 Updated by Gerrit Code Review over 1 year ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56239

#4 Updated by Mathias Brodala over 1 year ago

  • Subject changed from Refactor UserSettingsController to use a separate registry for user settings to Decouple TreeController from UserSettingsController

#5 Updated by Mathias Brodala over 1 year ago

  • Blocks Task #84369: Use ServerRequestInterface in UserSettingsController added

#6 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56239

#7 Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56239

#8 Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56239

#9 Updated by Gerrit Code Review over 1 year ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56239

#10 Updated by Gerrit Code Review over 1 year ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56239

#11 Updated by Gerrit Code Review over 1 year ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56239

#12 Updated by Saskia Schreiber over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#13 Updated by Benni Mack 11 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF