Task #84353

Epic #84272: Use PSR-7 ServerRequestInterface in backend controllers

Decouple TreeController from UserSettingsController

Added by Saskia Schreiber over 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2018-03-16
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
easy
Sprint Focus:
On Location Sprint

Related issues

Blocks TYPO3 Core - Task #84369: Use ServerRequestInterface in UserSettingsControllerClosedŁukasz Uznański2018-03-16

Actions
#1

Updated by Saskia Schreiber over 2 years ago

  • Status changed from New to In Progress
#2

Updated by Saskia Schreiber over 2 years ago

  • Subject changed from Use ServerRequestInterface in UserSettingsController to Refactor UserSettingsController to use a separate registry for user settings

The class UserSettingsController is currently a mixture of an ajax entry point and a registry for user related settings.

It provides an additional public method process() which is used inside the TreeController (to check for expanded pages).
This should be avoided as controllers should only provide proper actions as entry points.

Therefore there should be another class providing the settings for both UserSettingsController and TreeController.

#3

Updated by Gerrit Code Review over 2 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56239

#4

Updated by Mathias Brodala over 2 years ago

  • Subject changed from Refactor UserSettingsController to use a separate registry for user settings to Decouple TreeController from UserSettingsController
#5

Updated by Mathias Brodala over 2 years ago

  • Blocks Task #84369: Use ServerRequestInterface in UserSettingsController added
#6

Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56239

#7

Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56239

#8

Updated by Gerrit Code Review over 2 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56239

#9

Updated by Gerrit Code Review over 2 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56239

#10

Updated by Gerrit Code Review over 2 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56239

#11

Updated by Gerrit Code Review over 2 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56239

#12

Updated by Saskia Schreiber over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#13

Updated by Benni Mack about 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF