Task #84353: Decouple TreeController from UserSettingsController - TYPO3 Core - TYPO3 Forge

Custom queries

Accessibility
Easy tasks
Forge Triage
JavaScript issues
JavaScript Issues (w/o Epics/Stories)
My open issues
No feedback within 90 days
Open Bugs
Open issues of 10
Recently modified
Regressions
Stabilization Issues
Usability or UX

Actions

Copy link

Task #84353

closed

Epic #84272: Use PSR-7 ServerRequestInterface in backend controllers

Decouple TreeController from UserSettingsController

Added by Saskia Schreiber over 6 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Saskia Schreiber

Category:

Target version:

Start date:

2018-03-16

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

easy

Sprint Focus:

On Location Sprint

Related issues 1 (0 open — 1 closed)

Blocks TYPO3 Core - Task #84369: Use ServerRequestInterface in UserSettingsController

Closed

Łukasz Uznański

2018-03-16

Actions

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Saskia Schreiber over 6 years ago

Status changed from New to In Progress

Actions

Copy link

Updated by Saskia Schreiber over 6 years ago

Subject changed from Use ServerRequestInterface in UserSettingsController to Refactor UserSettingsController to use a separate registry for user settings

The class UserSettingsController is currently a mixture of an ajax entry point and a registry for user related settings.

It provides an additional public method process() which is used inside the TreeController (to check for expanded pages).
This should be avoided as controllers should only provide proper actions as entry points.

Therefore there should be another class providing the settings for both UserSettingsController and TreeController.

Actions

Copy link

Updated by Gerrit Code Review over 6 years ago

Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56239

Actions

Copy link

Updated by Mathias Brodala over 6 years ago

Subject changed from Refactor UserSettingsController to use a separate registry for user settings to Decouple TreeController from UserSettingsController

Actions

Copy link

Updated by Mathias Brodala over 6 years ago

Blocks Task #84369: Use ServerRequestInterface in UserSettingsController added

Actions

Copy link

Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56239

Actions

Copy link

Updated by Gerrit Code Review over 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56239

Actions

Copy link

Updated by Gerrit Code Review over 6 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56239

Actions

Copy link

Updated by Gerrit Code Review over 6 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56239

Actions

Copy link

#10

Updated by Gerrit Code Review over 6 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56239

Actions

Copy link

#11

Updated by Gerrit Code Review over 6 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56239

Actions

Copy link

#12