Task #84533

Ext:form configuration files name should transliterate accented characters instead of skipping them

Added by Tymoteusz Motylewski over 1 year ago. Updated 5 months ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Form Framework
Target version:
-
Start date:
2018-03-26
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Sprint Focus:
Remote Sprint

Description

the form configuration file created from form named "Jak dołączyć?"
should become:

/jakdolaczyc.yaml

and right now it's
/jakdoczy.yaml

The biggest pain is that when you have a name with many accented characters the file name becomes unreadable.

It's very easy to fix that like:

$csConverter = GeneralUtility::makeInstance(\TYPO3\CMS\Core\Charset\CharsetConverter::class);
$string = $csConverter->specCharsToASCII('utf-8', $string);

See similar change in Powermail:
https://github.com/einpraegsam/powermail/pull/37/files

Associated revisions

Revision edf5622b (diff)
Added by Dominik Merkel 8 months ago

[TASK] Transliterate accented characters

Convert accented characters in the form name
to ASCII characters

Resolves: #84533
Releases: master
Change-Id: I125a8df2f23d52d17ef2c1db4b5a9e113ae84f9c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60543
Tested-by: TYPO3com <>
Tested-by: Ralf Zimmermann <>
Reviewed-by: Oliver Klee <>
Reviewed-by: Ralf Zimmermann <>

Revision 02b6608e (diff)
Added by Dominik Merkel 8 months ago

[TASK] Transliterate accented characters

Convert accented characters in the form name
to ASCII characters

Resolves: #84533
Releases: master, 9.5
Change-Id: I125a8df2f23d52d17ef2c1db4b5a9e113ae84f9c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60551
Reviewed-by: Oliver Klee <>
Reviewed-by: Ralf Zimmermann <>
Tested-by: TYPO3com <>
Tested-by: Ralf Zimmermann <>

History

#1 Updated by Bjoern Jacob 8 months ago

  • Sprint Focus set to Remote Sprint

#2 Updated by Susanne Moog 8 months ago

  • Status changed from New to In Progress
  • Assignee set to Dominik M

#3 Updated by Gerrit Code Review 8 months ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60543

#4 Updated by Gerrit Code Review 8 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60543

#5 Updated by Gerrit Code Review 8 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60543

#6 Updated by Anonymous 8 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Gerrit Code Review 8 months ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60551

#8 Updated by Anonymous 8 months ago

  • Status changed from Under Review to Resolved

#9 Updated by Benni Mack 5 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF