Bug #84588

Int values for field will be converted to unix timestamp in module "DB check" -> Full search

Added by Manuel Selbach over 1 year ago. Updated 8 days ago.

Status:
Resolved
Priority:
Should have
Category:
-
Target version:
-
Start date:
2018-04-03
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

With the change in https://forge.typo3.org/issues/83675 every value will be converted into a unix timestamp even if you specify e.g. a UID or PID.

Example:

PID: 5134

This will bring back 99854182152 and the if condition is true in the introduced code:

if  (strtotime($conf['inputValue'])) {
    $conf['inputValue'] = strtotime($conf['inputValue']);
    if ($conf['inputValue1'] && strtotime($conf['inputValue1'])) {
        $conf['inputValue1'] = strtotime($conf['inputValue1']);
    }
}

Related issues

Related to TYPO3 Core - Bug #83675: DB Check : Full search : Advanced Query calendar problem Closed 2018-01-24
Related to TYPO3 Core - Bug #89154: QueryGenerator::cleanInputVal() - do not call strtotime on timestamp Resolved 2019-09-12

Associated revisions

Revision a85bdcae (diff)
Added by Sascha Egerer 8 days ago

[BUGFIX] Check date format before conversion in module "DB check"

With the change in https://forge.typo3.org/issues/83675 every value could
be converted into a unix timestamp, which leads to incorrect conversions
in some cases e.g. if an interger value like a pid 5134 is passed to the
method.

Releases: master, 9.5
Resolves: #84588
Resolves: #85020
Change-Id: Id92367bae3085015399ed89531c019e8aacd6510
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/56530
Tested-by: TYPO3com <>
Tested-by: Frank Nägler <>
Tested-by: Susanne Moog <>
Reviewed-by: Andreas Fernandez <>
Reviewed-by: Frank Nägler <>
Reviewed-by: Susanne Moog <>

Revision 1ef8bc4f (diff)
Added by Sascha Egerer 8 days ago

[BUGFIX] Check date format before conversion in module "DB check"

With the change in https://forge.typo3.org/issues/83675 every value could
be converted into a unix timestamp, which leads to incorrect conversions
in some cases e.g. if an interger value like a pid 5134 is passed to the
method.

Releases: master, 9.5
Resolves: #84588
Resolves: #85020
Change-Id: Id92367bae3085015399ed89531c019e8aacd6510
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61609
Tested-by: TYPO3com <>
Tested-by: Susanne Moog <>
Reviewed-by: Susanne Moog <>

Revision 71106bc8 (diff)
Added by Andreas Fernandez 6 days ago

[BUGFIX] Check for plain integer values in QueryGenerator::cleanInputVal()

Incoming field values are now also checked for being plain integers to
be able to handle timestamps properly.

Resolves: #89154
Related: #84588
Releases: master, 9.5
Change-Id: I220096faa563b3700eceb8a85839eed2a70d2170
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61670
Tested-by: Frank Nägler <>
Tested-by: TYPO3com <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Frank Nägler <>
Reviewed-by: Anja Leichsenring <>

Revision 4e1696a1 (diff)
Added by Andreas Fernandez 6 days ago

[BUGFIX] Check for plain integer values in QueryGenerator::cleanInputVal()

Incoming field values are now also checked for being plain integers to
be able to handle timestamps properly.

Resolves: #89154
Related: #84588
Releases: master, 9.5
Change-Id: I220096faa563b3700eceb8a85839eed2a70d2170
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61674
Tested-by: TYPO3com <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Anja Leichsenring <>

History

#1 Updated by Manuel Selbach over 1 year ago

  • Related to Bug #83675: DB Check : Full search : Advanced Query calendar problem added

#2 Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56530

#3 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56530

#4 Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56530

#5 Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56530

#6 Updated by Gerrit Code Review over 1 year ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56530

#7 Updated by Gerrit Code Review over 1 year ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56530

#8 Updated by Gerrit Code Review over 1 year ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56530

#9 Updated by Gerrit Code Review over 1 year ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56530

#10 Updated by Gerrit Code Review over 1 year ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56530

#11 Updated by Gerrit Code Review over 1 year ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56530

#12 Updated by Gerrit Code Review over 1 year ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56530

#13 Updated by Gerrit Code Review over 1 year ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56530

#14 Updated by Gerrit Code Review over 1 year ago

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56530

#15 Updated by Gerrit Code Review about 1 year ago

Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56530

#16 Updated by Gerrit Code Review 9 months ago

Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56530

#17 Updated by Gerrit Code Review 6 months ago

Patch set 17 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/56530

#18 Updated by Gerrit Code Review about 2 months ago

Patch set 18 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/56530

#19 Updated by Gerrit Code Review about 2 months ago

Patch set 19 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/56530

#20 Updated by Gerrit Code Review about 2 months ago

Patch set 20 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/56530

#21 Updated by Gerrit Code Review 8 days ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61609

#22 Updated by Sascha Egerer 8 days ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#23 Updated by Andreas Fernandez 7 days ago

  • Related to Bug #89154: QueryGenerator::cleanInputVal() - do not call strtotime on timestamp added

Also available in: Atom PDF