Feature #84594
closed
Separate e-mail subject field in the link wizard
100%
Description
In the current implementation, an editor can define a prefilled e-mail subject using the URL parameter "subject". The downside of this way is the requirement to encode these parameters (like spaces). Moreover, not every editor is familiar with these possibilities.
To make it easier for the editors, we should add a separate input field for the subject of the e-mail.
The subject can then be attached to the mailto as a url-encoded parameter when clicking on the "Set link" button.
Other possible parameters:
- cc
- bcc
- body
Files
Updated by
Updated by Guido S. over 6 years ago
Expanding the form isn't the problem (already implemented in my local patch). There are currently problems with the integration regarding config.spamProtectEmailAddresses. Coded spaces are converted from %20 to 0.
Updated by Jan Delius over 6 years ago
Shouldn't that be classified as a bug, then? According to https://tools.ietf.org/html/rfc6068#section-5 a space must be encoded as %20. TYPO3 supports the standard when using the configuration with spamProtectEmailAddresses here only partially or incorrectly.
Updated by Guido S. over 6 years ago
Hi Jan, the encoding via javascript and insert to CKEditor is fine. Normal output, too.
So far, the method, purely theoretically, did not have to pay attention to such signs. I will check it all over. Basically, this is a feature because it adds something new. If the spamProtection method returns something wrong, we might think about a bugfix. But I'm still watching.
Updated by Guido S. over 6 years ago
Okay...Core calls htmlspecialchars twice: CKEditor and then in ContentObjectRenderer.php This isn't a problem if we don't use new params at the EmailService ;-) I'll try to finish the patch at the weekend and then let's see. But it's definitely a feature for version 9.
Updated by Gerrit Code Review over 6 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56600
Updated by Gerrit Code Review over 6 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56600
Updated by Gerrit Code Review over 6 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56600
Updated by Gerrit Code Review over 6 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56600
Updated by Gerrit Code Review over 6 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56600
Updated by Gerrit Code Review almost 6 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56600
Updated by Helmut Hummel about 5 years ago
- Related to Bug #89264: Mailto links in RTE cannot use ampersand to add further arguments like subject=foo&body=bar added
Updated by Susanne Moog almost 5 years ago
- Status changed from Under Review to Accepted
Updated by Susanne Moog over 4 years ago
- Category set to Backend User Interface
Updated by Alexander Rotzsch over 3 years ago
+1
Waiting for this since a while and our editors, too. ;)
Updated by Gerrit Code Review almost 2 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77514
Updated by Gerrit Code Review almost 2 years ago
Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77514
Updated by Gerrit Code Review almost 2 years ago
Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77514
Updated by Gerrit Code Review almost 2 years ago
Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77514
Updated by Gerrit Code Review almost 2 years ago
Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77514
Updated by Gerrit Code Review almost 2 years ago
Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77514
Updated by Gerrit Code Review almost 2 years ago
Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77514
Updated by Jan Delius almost 2 years ago
- File clipboard-202301260945-imq3i.png clipboard-202301260945-imq3i.png added
- File clipboard-202301260946-jvr1p.png clipboard-202301260946-jvr1p.png added
- File clipboard-202301260946-8wii3.png clipboard-202301260946-8wii3.png added
As requested in https://review.typo3.org/c/Packages/TYPO3.CMS/+/77514/comments/e0772843_4f0602a4, here are some screenshots of the non-working multiline body.
Wizard:
After "Set Link":
After reopen link wizard:
Updated by Gerrit Code Review almost 2 years ago
Patch set 8 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77514
Updated by Gerrit Code Review almost 2 years ago
Patch set 9 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77514
Updated by Gerrit Code Review almost 2 years ago
Patch set 10 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77514
Updated by Gerrit Code Review almost 2 years ago
Patch set 11 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77514
Updated by Gerrit Code Review almost 2 years ago
Patch set 12 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77514
Updated by Gerrit Code Review almost 2 years ago
Patch set 13 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77514
Updated by Gerrit Code Review almost 2 years ago
Patch set 14 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77514
Updated by Gerrit Code Review almost 2 years ago
Patch set 15 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77514
Updated by Gerrit Code Review almost 2 years ago
Patch set 16 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77514
Updated by Gerrit Code Review almost 2 years ago
Patch set 17 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77514
Updated by Gerrit Code Review almost 2 years ago
Patch set 18 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77514
Updated by Gerrit Code Review almost 2 years ago
Patch set 19 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77514
Updated by Gerrit Code Review almost 2 years ago
Patch set 20 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77514
Updated by Gerrit Code Review over 1 year ago
Patch set 21 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77514
Updated by Gerrit Code Review over 1 year ago
Patch set 22 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77514
Updated by Gerrit Code Review over 1 year ago
Patch set 23 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77514
Updated by Gerrit Code Review over 1 year ago
Patch set 24 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77514
Updated by Gerrit Code Review over 1 year ago
Patch set 25 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77514
Updated by Gerrit Code Review over 1 year ago
Patch set 26 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77514
Updated by Gerrit Code Review over 1 year ago
Patch set 27 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77514
Updated by Gerrit Code Review over 1 year ago
Patch set 28 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77514
Updated by Gerrit Code Review over 1 year ago
Patch set 29 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77514
Updated by Gerrit Code Review over 1 year ago
Patch set 30 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77514
Updated by Muhammad Suleman over 1 year ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 0930a80f7a433b3a8720658ac036cab6a6238cf8.
Updated by