Feature #84594

Separate e-mail subject field in the link wizard

Added by Jan Delius over 1 year ago. Updated 11 months ago.

Status:
Under Review
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2018-04-04
Due date:
% Done:

0%

PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

In the current implementation, an editor can define a prefilled e-mail subject using the URL parameter "subject". The downside of this way is the requirement to encode these parameters (like spaces). Moreover, not every editor is familiar with these possibilities.

To make it easier for the editors, we should add a separate input field for the subject of the e-mail.

The subject can then be attached to the mailto as a url-encoded parameter when clicking on the "Set link" button.

Other possible parameters:

  • cc
  • bcc
  • body

Related issues

Related to TYPO3 Core - Bug #89264: Mailto links in RTE cannot use ampersand to add further arguments like subject=foo&body=bar Under Review 2019-09-25

History

#1 Updated by Georg Ringer over 1 year ago

  • Description updated (diff)

#2 Updated by Guido S. over 1 year ago

Expanding the form isn't the problem (already implemented in my local patch). There are currently problems with the integration regarding config.spamProtectEmailAddresses. Coded spaces are converted from %20 to 0.

#3 Updated by Jan Delius over 1 year ago

Shouldn't that be classified as a bug, then? According to https://tools.ietf.org/html/rfc6068#section-5 a space must be encoded as %20. TYPO3 supports the standard when using the configuration with spamProtectEmailAddresses here only partially or incorrectly.

#4 Updated by Guido S. over 1 year ago

Hi Jan, the encoding via javascript and insert to CKEditor is fine. Normal output, too.

So far, the method, purely theoretically, did not have to pay attention to such signs. I will check it all over. Basically, this is a feature because it adds something new. If the spamProtection method returns something wrong, we might think about a bugfix. But I'm still watching.

#5 Updated by Guido S. over 1 year ago

Okay...Core calls htmlspecialchars twice: CKEditor and then in ContentObjectRenderer.php This isn't a problem if we don't use new params at the EmailService ;-) I'll try to finish the patch at the weekend and then let's see. But it's definitely a feature for version 9.

#6 Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56600

#7 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56600

#8 Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56600

#9 Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56600

#10 Updated by Gerrit Code Review over 1 year ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56600

#11 Updated by Gerrit Code Review 11 months ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56600

#12 Updated by Helmut Hummel 24 days ago

  • Related to Bug #89264: Mailto links in RTE cannot use ampersand to add further arguments like subject=foo&body=bar added

Also available in: Atom PDF