Feature #84774

Hide Override finisher settings if there are no finisher

Added by Kay Strobach about 1 year ago. Updated 30 days ago.

Status:
Resolved
Priority:
Should have
Assignee:
Category:
Form Framework
Target version:
-
Start date:
2018-04-17
Due date:
% Done:

100%

PHP Version:
7.2
Tags:
Complexity:
Sprint Focus:
Remote Sprint

Description

Steps to reproduce:

  • create a form e.g.:
type: Form
identifier: test
label: test
prototypeName: standard
renderables:
  -
    type: Page
    identifier: page-1
    label: Step
    renderables:
      -
        type: DatePicker
        identifier: datepicker-1
        label: 'Date picker'
        properties:
          dateFormat: Y-m-d
          enableDatePicker: false
          displayTimeSelector: false

What i expect:

if there are no finishers hide the checkbox Override finisher settings

What happens

it is still there.

2018-04-17_23-12-29.png View (50.6 KB) Kay Strobach, 2018-04-17 23:14

Associated revisions

Revision 84695c6f (diff)
Added by Michael Waack 30 days ago

[TASK] Avoid pointless finisher override checkbox

The form plugin now only renders the checkbox for overriding
the finishers if finishers are available at all. Also finishers
without options are ignored.

Resolves: #84774
Releases: master
Change-Id: I1165d054340457fdd219024f28b877a21458b603
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60570
Tested-by: Mathias Brodala <>
Tested-by: Björn Jacob <>
Tested-by: Dominik Merkel <>
Tested-by: Ralf Zimmermann <>
Reviewed-by: Mathias Brodala <>
Reviewed-by: Björn Jacob <>
Reviewed-by: Dominik Merkel <>
Reviewed-by: Ralf Zimmermann <>

History

#1 Updated by Kay Strobach about 1 year ago

#2 Updated by Bjoern Jacob about 1 year ago

  • Sprint Focus set to Remote Sprint

#3 Updated by Susanne Moog 9 months ago

  • Target version changed from 9 LTS to Candidate for patchlevel

#4 Updated by Bjoern Jacob about 2 months ago

  • Tracker changed from Bug to Task

#5 Updated by Bjoern Jacob about 2 months ago

  • Tracker changed from Task to Feature
  • Target version deleted (Candidate for patchlevel)

#6 Updated by Michael Waack about 1 month ago

  • Assignee set to Michael Waack

#7 Updated by Gerrit Code Review about 1 month ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60570

#8 Updated by Gerrit Code Review about 1 month ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60570

#9 Updated by Gerrit Code Review about 1 month ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60570

#10 Updated by Gerrit Code Review about 1 month ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60570

#11 Updated by Gerrit Code Review 30 days ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60570

#12 Updated by Gerrit Code Review 30 days ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60570

#13 Updated by Gerrit Code Review 30 days ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60570

#14 Updated by Michael Waack 30 days ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF