Task #84993

Deprecate BackendUserAuthentication ->getTSConfigVal() and ->getTSConfigProp()

Added by Christian Kuhn over 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2018-05-13
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Related issues

Related to TYPO3 Core - Task #84982: Return full userTS in getTSConfig() Closed 2018-05-12
Related to TYPO3 Core - Bug #85213: BE users are unable to deactivate checkboxes in the Filelist Closed 2018-06-11
Related to TYPO3 Core - Bug #86882: TSConfig "options.contextMenu.table.pages.tree.disableItems" not working Closed 2018-11-08

Associated revisions

Revision d44856e5 (diff)
Added by Christian Kuhn over 1 year ago

[TASK] Deprecate getTSConfigVal() and getTSConfigProp()

The patch deprecates BackendUserAuthentication->getTSConfigVal()
and ->getTSConfigProp() and adapts usages to rely on getTSConfig()
without arguments. The array nesting is done directly within
consuming code and is combined with ?? to a fallback value.
Advantages:
  • Expensive and recursive string operations within
    getTSConfig() are not used anymore.
  • The weird 'value' / 'property' based sub array
    juggling is gone.
  • Full TSconfig path including fallback can be easily
    seen within consuming code
  • Notice free array access using null coalescence operator

Change-Id: I6d5777ebd533dcfdc6018e0226bfb3e513cfa652
Resolves: #84993
Related: #84982
Releases: master
Reviewed-on: https://review.typo3.org/56953
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Stefan Neufeind <>
Tested-by: Stefan Neufeind <>
Tested-by: TYPO3com <>
Reviewed-by: Wouter Wolters <>
Tested-by: Wouter Wolters <>

Revision 1e8b2d45 (diff)
Added by Frank Naegler over 1 year ago

[BUGFIX] Fix broken ?? checks by adding required brackets

Resolves: #85213
Related: #84993
Releases: master
Change-Id: Ib8cd46951cb5032a7554042e2d8a7a052102788b
Reviewed-on: https://review.typo3.org/57174
Tested-by: TYPO3com <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

History

#1 Updated by Christian Kuhn over 1 year ago

  • Related to Task #84982: Return full userTS in getTSConfig() added

#2 Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56953

#3 Updated by Gerrit Code Review over 1 year ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56953

#4 Updated by Gerrit Code Review over 1 year ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56953

#5 Updated by Gerrit Code Review over 1 year ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56953

#6 Updated by Christian Kuhn over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Frank Naegler over 1 year ago

  • Related to Bug #85213: BE users are unable to deactivate checkboxes in the Filelist added

#8 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

#9 Updated by Georg Ringer 11 months ago

  • Related to Bug #86882: TSConfig "options.contextMenu.table.pages.tree.disableItems" not working added

Also available in: Atom PDF