Project

General

Profile

Actions

Bug #85068

closed

IpAnonymizationAdditionalFieldProvider causes javscript problem in Scheduler

Added by Sven Juergens over 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Backend JavaScript
Target version:
Start date:
2018-05-23
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

Hi,

Please take a look at the attached gifs first

in the scheduler is a Javascript snippet which write the defaultNumberOfDays in the input Field "tx_scheduler[scheduler_tableGarbageCollection_numberOfDays]"
(see should-be-8.7.13.gif)

to get this information TableGarbageCollectionAdditionalFieldProvider set a Javascript var

  $fieldHtml[] = '<script type="text/javascript">/*<![CDATA[*/<!--';
        $fieldHtml[] = 'var defaultNumberOfDays = ' . json_encode($this->defaultNumberOfDays) . ';';
        $fieldHtml[] = '// -->/*]]>*/</script>';

but IpAnonymizationAdditionalFieldProvider also sets this variable, but empty

  // Add js array for default 'number of days' values
        $fieldHtml[] = '<script type="text/javascript">/*<![CDATA[*/<!--';
        $fieldHtml[] = 'var defaultNumberOfDays = ' . json_encode($this->defaultNumberOfDays) . ';';
        $fieldHtml[] = '// -->/*]]>*/</script>';

the result in html is

<script type="text/javascript">/*<![CDATA[*/<!--
var defaultNumberOfDays = {"sys_log":180,"sys_history":30,"index_stat_search":90,"tx_formhandler_log":180};
// -->/*]]>*/</script></div></div></div>
...
...
...
<script type="text/javascript">/*<![CDATA[*/<!--
var defaultNumberOfDays = [];
// -->/*]]>*/</script></div></div></div>

Files

bug-8.7.14-and-8.7.15.gif (325 KB) bug-8.7.14-and-8.7.15.gif Sven Juergens, 2018-05-23 14:12
should-be-8.7.13.gif (469 KB) should-be-8.7.13.gif Sven Juergens, 2018-05-23 14:13
Actions #1

Updated by Christian Kuhn over 6 years ago

  • Is Regression set to Yes
Actions #2

Updated by Riccardo De Contardi over 6 years ago

  • Category set to Backend JavaScript
Actions #3

Updated by Frank Nägler over 6 years ago

  • Status changed from New to Accepted
  • Target version set to 9.3
Actions #4

Updated by Frank Nägler over 6 years ago

  • Status changed from Accepted to In Progress
  • Assignee set to Frank Nägler
Actions #5

Updated by Gerrit Code Review over 6 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57136

Actions #6

Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57136

Actions #7

Updated by Gerrit Code Review over 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57136

Actions #8

Updated by Gerrit Code Review over 6 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57164

Actions #9

Updated by Frank Nägler over 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #10

Updated by Gerrit Code Review over 6 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57165

Actions #11

Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57165

Actions #12

Updated by Frank Nägler over 6 years ago

  • Status changed from Under Review to Resolved
Actions #13

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF