Bug #85228

Invalid count query in SuggestWizardDefaultReceiver

Added by Alexander Stehlik almost 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2018-06-11
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
easy
Is Regression:
Yes
Sprint Focus:

Description

This is a regression from #78129:

The count query in the queryTable() method in the SuggestWizardDefaultReceiver does not respect the constraints set in the constructor and it is invalid because the table name is missing.

As far as I can see the count query is not needed and can be removed.

screenshot.png View (626 KB) Oliver Hader, 2018-06-12 10:23


Related issues

Related to TYPO3 Core - Bug #78129: Statement::rowCount not reliable for SELECT queries Closed 2016-10-02

Associated revisions

Revision 4c0f3aa0 (diff)
Added by Alexander Stehlik almost 2 years ago

[BUGFIX] Respect query constraints in suggest receiver count

The query builder that fetches the results in the suggest
receiver is re-used to get the correct count of available
results.

Resolves: #85228
Relates: #78129
Releases: master
Change-Id: I2df36d4668cdde616242912e7f0d53bcded18021
Reviewed-on: https://review.typo3.org/57192
Tested-by: TYPO3com <>
Reviewed-by: Susanne Moog <>
Tested-by: Susanne Moog <>
Reviewed-by: Markus Klein <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

History

#1 Updated by Alexander Stehlik almost 2 years ago

  • Related to Bug #78129: Statement::rowCount not reliable for SELECT queries added

#2 Updated by Gerrit Code Review almost 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57192

#3 Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57192

#4 Updated by Oliver Hader almost 2 years ago

  • Is Regression set to Yes

Confirmed exception

An exception occurred while executing 'SELECT COUNT(`uid`)':

Unknown column 'uid' in 'field list'

#5 Updated by Oliver Hader almost 2 years ago

How to reproduce:
  • use TYPO3 v9 (master)
  • edit some element making use of the suggest wizard in form engine, e.g. pages, "appearance" tab, field "replace content"
  • type in some name that shall be auto completed, e.g. "media"
  • see the HTTP 500 error in the browser's console pointing out the SQL error

#6 Updated by Gerrit Code Review almost 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57192

#7 Updated by Alexander Stehlik almost 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#8 Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF