Bug #85251

List Module does not show edit links for LiveSearch results

Added by Stefan P 11 months ago. Updated 17 days ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2018-06-13
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

I could not re-open a ticket (see #85230), but #63916 was falsely closed.

When coming from the search box, the list view does not show edit buttons for the items of any table but pages when searching as a non-admin. In regular list-view non-admins see the edit button (if granted edit rights, of course).


Related issues

Related to TYPO3 Core - Bug #63916: List Module does not show edit links for LiveSearch results Accepted 2014-12-16

Associated revisions

Revision c3738014 (diff)
Added by Guido Schmechel 3 months ago

[BUGFIX] Calc permissions for edit links correctly

If an editor searches for something in LiveSearch, the
permission to edit non-pages records is now calculated correctly.

Resolves: #85251
Releases: master, 9.5
Change-Id: I1e28c7d431f24d9afcf3b0682fdc53a515fd8441
Reviewed-on: https://review.typo3.org/c/57496
Tested-by: TYPO3com <>
Tested-by: Benni Mack <>
Tested-by: Jürgen Venne <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Benni Mack <>
Reviewed-by: Jürgen Venne <>
Reviewed-by: Anja Leichsenring <>

Revision 15935f1e (diff)
Added by Guido Schmechel 3 months ago

[BUGFIX] Calc permissions for edit links correctly

If an editor searches for something in LiveSearch, the
permission to edit non-pages records is now calculated correctly.

Resolves: #85251
Releases: master, 9.5
Change-Id: I1e28c7d431f24d9afcf3b0682fdc53a515fd8441
Reviewed-on: https://review.typo3.org/c/59829
Tested-by: TYPO3com <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Anja Leichsenring <>

History

#1 Updated by Guido Schmechel 11 months ago

I can reproduce it with 9.4.dev.

I found out that $this->calcPerms is 0 in typo3\sysext\recordlist\Classes\RecordList\DatabaseRecordList.php at line 1953. I don't know how the core fills in this permission info.

#2 Updated by Gerrit Code Review 11 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57496

#3 Updated by Gerrit Code Review 11 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57496

#4 Updated by Gerrit Code Review 11 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57496

#5 Updated by Gerrit Code Review 11 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57496

#6 Updated by Christian Kuhn 9 months ago

  • Related to Bug #63916: List Module does not show edit links for LiveSearch results added

#7 Updated by Gerrit Code Review 9 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57496

#8 Updated by Gerrit Code Review 8 months ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57496

#9 Updated by Gerrit Code Review 5 months ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57496

#10 Updated by Gerrit Code Review 3 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59829

#11 Updated by Guido Schmechel 3 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#12 Updated by Benni Mack 17 days ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF