Bug #85360: Doubled confirmation message after form submit - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #85360

closed

Doubled confirmation message after form submit

Added by Georg Großberger over 6 years ago. Updated over 6 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Form Framework

Target version:

Start date:

2018-06-23

Due date:

% Done:

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

easy

Is Regression:

Sprint Focus:

Description

After a form was submitted, the content of the Confirmation finisher is shown twice.

This is because the finisher uses setContent on the response object, which is passed down from the controller via the rendering context. Extbase then takes that same content and calls appendContent, on the same instance, with the content it already contains. This results in the same message being showed twice.

This can be avoided by using a separate instance of the Response class, within the form context.

Affects 8 LTS and current master

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Gerrit Code Review over 6 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57337

Actions

Copy link

Updated by Gerrit Code Review over 6 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57338

Actions

Copy link

Updated by Ralf Zimmermann over 6 years ago

Related to Bug #84495: Confirmation finisher duplicate output added

Actions

Copy link

Updated by Ralf Zimmermann over 6 years ago

Can you provide your steps to reproduce this?

This issue was fixed with https://review.typo3.org/#/c/56377/ and https://review.typo3.org/#/c/56831/

This form definition, rendered through the form content element displays the confirmation message only once (8.7.17, master):

type: Form
identifier: test
label: test
prototypeName: standard
finishers:
  -
    identifier: Confirmation
    options:
      message: xxx
      contentElementUid: ''
renderables:
  -
    type: Page
    identifier: page-1
    label: Step

Actions

Copy link