Bug #85440

UI: Scan extension files: Misleading Button-text

Added by David Bruchmann over 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Install Tool
Target version:
Start date:
2018-06-30
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
7.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

See attached Screenshot, currently there is nothing "Scanning ...".

Scan-extension-files_buttons.png View (32.5 KB) David Bruchmann, 2018-06-30 10:53


Related issues

Related to TYPO3 Core - Task #84772: Improve Install Tool behaviour Closed 2018-04-17

Associated revisions

Revision ba63d4a0 (diff)
Added by Andreas Fernandez over 1 year ago

[BUGFIX] Scan extension by clicking panel

The extension scanner now scans an extension by opening its
panel again.

Resolves: #85440
Releases: master
Change-Id: I7b72f8c658d200c5c4d4ca90f7d6b55828c33efd
Reviewed-on: https://review.typo3.org/57493
Reviewed-by: Mona Muzaffar <>
Tested-by: Mona Muzaffar <>
Reviewed-by: Jürgen Venne <>
Tested-by: Jürgen Venne <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>

History

#1 Updated by David Bruchmann over 1 year ago

Additionally each extension-area is missing a border on the right side.

#2 Updated by Christian Kuhn over 1 year ago

that's a bug that has been introduced when the card content has been put into the install tool modals: if opening an extension, the scanner should start for that extension, this is not the case anymore, probably some broken js event or trigger. a patch to fix this would be great.

#3 Updated by Christian Kuhn over 1 year ago

  • Related to Task #84772: Improve Install Tool behaviour added

#4 Updated by David Bruchmann over 1 year ago

If someone has many extensions I think it's not desired, that scanning every extension is started directly.
So I propose a butten with "Scan" and if clicked the text is changing to "Scanning..."

#5 Updated by Christian Kuhn over 1 year ago

i don't see the point: clicking on "scan all" triggers a scan all. opening a single extension triggers scan of that extension. not having the latter does not make sense, i think that is pretty neat and convenient.

#6 Updated by David Bruchmann over 1 year ago

The point is that you proposed to fix some javascript related to some automatic behavior.
But according to your own words the automatic behavior is not desired anymore.

#7 Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57493

#8 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57493

#9 Updated by Andreas Fernandez over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#10 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF