Task #84772

Improve Install Tool behaviour

Added by Philipp Hamid over 1 year ago. Updated 12 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2018-04-17
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

  1. simple action needs to be directly accessible
  2. streamline layout with backend
  3. replace gridder through modals

Related issues

Related to TYPO3 Core - Bug #84832: Rendering of DatabaseAnalyzer output is recursive Closed 2018-04-21
Related to TYPO3 Core - Bug #85440: UI: Scan extension files: Misleading Button-text Closed 2018-06-30
Related to TYPO3 Core - Bug #85419: Finding ImageMagick / GraphicsMagick in additionalSearchPath in Configuration Presets broken Closed 2018-06-28
Related to TYPO3 Core - Bug #85676: Clean up install tool cardsAction Closed 2018-07-29
Related to TYPO3 Core - Bug #85923: Update TYPO3 Core fails Closed 2018-08-22
Related to TYPO3 Core - Bug #86245: Install tool css details Closed 2018-09-13
Duplicated by TYPO3 Core - Task #83018: Use modal api of core in install tool Closed 2017-11-17

Associated revisions

Revision 11c55be2 (diff)
Added by Philipp Hamid over 1 year ago

[TASK] Improve Install Tool UX

Implemented card layout and modals instead of gridder.
Action buttons like clear all cache trigger it's action now directly.
Upcomming Notfications are displayed via backend notifications.
Content for modals is completly loaded via ajax calls. The icon api
is now available for the standalone mode of the install tool.
"libs/chosen" is imported in backend.scss to display proper styling of
chosen selects in modals.

Releases: master
Resolves: #84772
Change-Id: Ib5efbcd45c00b9c3dc973446e3fc1ef39c1f1146
Reviewed-on: https://review.typo3.org/56065
Tested-by: TYPO3com <>
Reviewed-by: Andreas Fernandez <>
Tested-by: Andreas Fernandez <>
Reviewed-by: Benjamin Kott <>
Tested-by: Benjamin Kott <>
Reviewed-by: Frank Naegler <>
Tested-by: Frank Naegler <>

Revision 161ba9bd (diff)
Added by Andreas Fernandez over 1 year ago

[BUGFIX] Resolve recursing DOM manipulation

To fix the recursive DOM manipulation, the selector class name used to
find the "blueprint" is removed from the actual clone.

Resolves: #84832
Related: #84772
Releases: master
Change-Id: Id1a26ca9d20d95c8395998c6783715e677f16780
Reviewed-on: https://review.typo3.org/56772
Reviewed-by: Frank Naegler <>
Tested-by: Frank Naegler <>
Reviewed-by: Oliver Hader <>
Tested-by: Oliver Hader <>
Tested-by: TYPO3com <>
Reviewed-by: Wouter Wolters <>
Reviewed-by: Philipp Hamid <>
Tested-by: Philipp Hamid <>
Reviewed-by: Andreas Fernandez <>
Tested-by: Andreas Fernandez <>

Revision 77a0ae02 (diff)
Added by Christian Kuhn about 1 year ago

[BUGFIX] Clean up install tool cardsAction

With the install tool "make all modals" rewrite in #84772,
the initial views are stupid and don't need fluid assignments
like tokens anymore: Card details are now handled in single
"getContent" actions per card.
Left over assignments are removed with the patch.
Furthermore, the core updater getContent action entirely missed
some fluid assignments and the "search in custom path" image
preset functionality is restored.

Resolves: #85676
Resolves: #85419
Related: #84772
Releases: master
Change-Id: I4b2054338b500d4f8d08f83f76a3efc66511a529
Reviewed-on: https://review.typo3.org/57715
Tested-by: TYPO3com <>
Reviewed-by: Susanne Moog <>
Tested-by: Susanne Moog <>
Reviewed-by: Wouter Wolters <>
Tested-by: Wouter Wolters <>

Revision b4008949 (diff)
Added by Christian Kuhn about 1 year ago

[BUGFIX] Adapt view related install tool details

With the install tool move to modals, various details on CSS
level broke: The modal HTML is on top level in backend and thus
not within the content-iframe, so styles defined in install.css
loaded in the iframe do not kick in. Since the standalone install
tool does not use iframes, there are various differences on view
level between standalone and embedded-in-backend version, usually
with the embedded version looking more ugly than standalone.

The install.css is not very different from backend.css anyway,
so we resolve various details with the patch, kick install.css
entirely and rely soley on backend.css, even for the installer.

Details:
  • <hr> shows a border again in modals in embedded, broken since
    modal patch
  • image processing view has borders and other details again in
    embedded verision, broken since modal patch
  • removed 'fixed save button location' for 'all configuration' code.
    This broke with the modal patch, the code does not do anything
    useful at the moment. A solution needs a change of the modal js
    to render the buttons to modal-footer instead. This is too complex
    for this patch and may be done with another patch.
  • A couple of classes to easily limit styles to installer and
    maintenance parts
  • Remove left overs from old install-tool menu approach that
    have not been cleanup up, yet.

Resolves: #86245
Related: #84772
Releases: master
Change-Id: I4d21677331112a48f84b0cf48a574999128a15b7
Reviewed-on: https://review.typo3.org/58269
Tested-by: TYPO3com <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

History

#1 Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56065

#2 Updated by Gerrit Code Review over 1 year ago

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56065

#3 Updated by Gerrit Code Review over 1 year ago

Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56065

#4 Updated by Gerrit Code Review over 1 year ago

Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56065

#5 Updated by Gerrit Code Review over 1 year ago

Patch set 17 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56065

#6 Updated by Gerrit Code Review over 1 year ago

Patch set 18 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56065

#7 Updated by Gerrit Code Review over 1 year ago

Patch set 19 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56065

#8 Updated by Gerrit Code Review over 1 year ago

Patch set 20 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56065

#9 Updated by Philipp Hamid over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#10 Updated by Andreas Fernandez over 1 year ago

  • Related to Bug #84832: Rendering of DatabaseAnalyzer output is recursive added

#11 Updated by Christian Kuhn about 1 year ago

  • Related to Bug #85440: UI: Scan extension files: Misleading Button-text added

#12 Updated by Christian Kuhn about 1 year ago

  • Duplicated by Task #83018: Use modal api of core in install tool added

#13 Updated by Christian Kuhn about 1 year ago

  • Related to Bug #85419: Finding ImageMagick / GraphicsMagick in additionalSearchPath in Configuration Presets broken added

#14 Updated by Christian Kuhn about 1 year ago

  • Related to Bug #85676: Clean up install tool cardsAction added

#15 Updated by Anja Leichsenring about 1 year ago

  • Related to Bug #85923: Update TYPO3 Core fails added

#16 Updated by Christian Kuhn about 1 year ago

  • Related to Bug #86245: Install tool css details added

#17 Updated by Benni Mack 12 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF