Task #85477: Replace substr(...) with strpos(...) - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Task #85477

closed

Replace substr(...) with strpos(...)

Added by Wouter Wolters almost 6 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Wouter Wolters

Category:

Code Cleanup

Target version:

Start date:

2018-07-04

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Sprint Focus:

Description

'substr(...)' invokes additional memory allocation (more work for GC), which is not needed in the context. 'strpos(...)' will do the same job with CPU resources only. If you are eager for performance in your project this inspection in combination with "Fixed-time string starts with checks" (which is disabled by default) would be a good option.

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Gerrit Code Review almost 6 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57466

Actions

Copy link

Updated by Gerrit Code Review almost 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57466

Actions

Copy link

Updated by Gerrit Code Review almost 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57466

Actions

Copy link

Updated by Gerrit Code Review almost 6 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57466

Actions

Copy link

Updated by Gerrit Code Review almost 6 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57466

Actions

Copy link

Updated by Gerrit Code Review almost 6 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57466

Actions

Copy link

Updated by Gerrit Code Review over 5 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57466

Actions

Copy link