Bug #85544

The form definition upgrade wizard does not update all relevant plugin settings

Added by Ralf Zimmermann over 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Must have
Category:
Form Framework
Start date:
2018-07-12
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

The form definition upgrade wizard (rename .yaml => .form.yaml) does not update all relevant plugin settings.
The form definition renaming wizard updates the "settings.persistenceIdentifier" property within the flexform but ignores the "Override finisher settings" options.

The form plugin tries to prevent unintentionally finisher settings overrides.
This could be happened if you have an already overridden finisher option and select another form definition.
In some cases it could be, that a finisher override from form definition "A" is set as an finisher override for form definition "B" if you switch from form definition "A" to "B".
To prevent this, every dynamic flexform sheet (every finisher, which allows the form plugin to override settings, appears in another tab) has an unique name which is composed of properties of the form definition.
This name is an md5 hash from the following form definition properties:

  • persistenceIdentifier
  • prototypeName
  • formIdentifier
  • finisherIdentifier

Since the form definition renaming wizard renames the "persistenceIdentifier" propery, the calculation for the unique name for the flexform sheets for the finisher overrides results in another md5 hash. The result is that the corresponding sheets are no longer associated with the currently selected form and all overridable finisher options are empty.


Related issues

Related to TYPO3 Core - Bug #85685: Uncaught TYPO3 Exception in form update wizard Closed 2018-07-30
Related to TYPO3 Core - Task #82328: EXT:form - ship own uploads (sub)folder for form definitions Closed 2017-09-07

Associated revisions

Revision 650ce3d5 (diff)
Added by Ralf Zimmermann about 1 year ago

[BUGFIX] The form upgrade wizard must update all plugin settings

The form definition renaming upgrade wizard renames the persistence
identifier within the form plugin flexform.
As a result, finisher overrides can no longer be properly assigned.
This patch adds an upgrade wizard which will be able to restore these
finisher overrides.

Resolves: #85544
Releases: master, 8.7
Change-Id: Idf1ffd8432fed88431b9a0feb407f42df3304401
Reviewed-on: https://review.typo3.org/57582
Tested-by: TYPO3com <>
Tested-by: Susanne Moog <>
Reviewed-by: Susanne Moog <>
Reviewed-by: Oliver Hader <>
Tested-by: Oliver Hader <>

Revision 3a85f685 (diff)
Added by Ralf Zimmermann about 1 year ago

[BUGFIX] The form upgrade wizard must update all plugin settings

The form definition renaming upgrade wizard renames the persistence
identifier within the form plugin flexform.
As a result, finisher overrides can no longer be properly assigned.
This patch adds an upgrade wizard which will be able to restore these
finisher overrides.

Resolves: #85544
Releases: master, 8.7
Change-Id: Idf1ffd8432fed88431b9a0feb407f42df3304401
Reviewed-on: https://review.typo3.org/57731
Tested-by: TYPO3com <>
Reviewed-by: Oliver Hader <>
Tested-by: Oliver Hader <>

Revision 1caf66a8 (diff)
Added by Ralf Zimmermann about 1 year ago

[BUGFIX] The form upgrade wizard must update all plugin settings

The form definition renaming upgrade wizard renames the persistence
identifier within the form plugin flexform.
As a result, finisher overrides can no longer be properly assigned.
This patch adds an upgrade wizard which will be able to restore these
finisher overrides.

Resolves: #85544
Releases: master, 8.7
Change-Id: Idf1ffd8432fed88431b9a0feb407f42df3304401
Reviewed-on: https://review.typo3.org/57733
Reviewed-by: Oliver Hader <>
Tested-by: Oliver Hader <>

History

#1 Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57582

#2 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57582

#3 Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57582

#4 Updated by Ralf Zimmermann over 1 year ago

  • Is Regression set to Yes

#5 Updated by RVVN no-lastname-given over 1 year ago

Hi,

as I said on the slack channel, patch 3 didn't work for me.

I used the following way :
• rename file with .form.yaml suffix
• run the first wizard "rename to .form.yaml"
• run the second wizard "fix flexform after rename"

Sheets indexes have been modified in DB by the 2nd wizard but the form plugin still can't "use" these sheets. All the values displayed in finishers tabs are the default ones, and some are missing (Redirect Page for example)

Maybe hashes still are wrong ?

#6 Updated by Ralf Zimmermann over 1 year ago

Thanks, iam still on it...

#7 Updated by RVVN no-lastname-given over 1 year ago

OK, no pressure, I just wanted to report at the right place ;)

#8 Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57582

#9 Updated by Gerrit Code Review over 1 year ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57582

#10 Updated by Gerrit Code Review about 1 year ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57582

#11 Updated by Oliver Hader about 1 year ago

  • Target version set to 7.6.31 & 8.7.18 & 9.3.3

#12 Updated by Gerrit Code Review about 1 year ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57582

#13 Updated by Gerrit Code Review about 1 year ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57582

#14 Updated by Gerrit Code Review about 1 year ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57582

#15 Updated by Ralf Zimmermann about 1 year ago

  • Related to Bug #85685: Uncaught TYPO3 Exception in form update wizard added

#16 Updated by Gerrit Code Review about 1 year ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57582

#17 Updated by Gerrit Code Review about 1 year ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57582

#18 Updated by Gerrit Code Review about 1 year ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57582

#19 Updated by Gerrit Code Review about 1 year ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57582

#20 Updated by Gerrit Code Review about 1 year ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57731

#21 Updated by Gerrit Code Review about 1 year ago

Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57731

#22 Updated by Gerrit Code Review about 1 year ago

Patch set 3 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57731

#23 Updated by Gerrit Code Review about 1 year ago

Patch set 1 for branch 9.3 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57733

#24 Updated by Ralf Zimmermann about 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#25 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

#26 Updated by Ralf Hettinger about 1 year ago

  • Related to Task #82328: EXT:form - ship own uploads (sub)folder for form definitions added

Also available in: Atom PDF