Project

General

Profile

Actions

Bug #85583

closed

Filelist module inaccessible after creating folder with upper case chars

Added by Torben Hansen over 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
File Abstraction Layer (FAL)
Target version:
-
Start date:
2018-07-17
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
7.1
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

On a server with a case sensitive file system, new created directories in the TYPO3 backend are not converted to lower case, when the default storage is not configured to use case sensitive identifiers.

Steps to reproduce:

1. Make sure, your TYPO3 is running on a case sensitive filesystem (e.g. linux)
2. Make sure, "Uses case sensitive identifiers" is not checked for the default storage
3. Open filelist module and create a directory named "Test1234Test"
4. TYPO3 throws an exception "Folder "/test1234test/" does not exist."

The directory name in FAL is likely converted to lower case, but the directory is created in as "Test1234Test"

drwxrwsr-x 2 www-data www-data  4096 Jul 17 20:41 Test1234Test/

The whole filelist module is now now accessible any more and the folder needs to be removed/renamed manually on the filesystem.

Actions #1

Updated by Torben Hansen over 6 years ago

When creating a new file in the filelist module, the "TYPO3\CMS\Core\Resource\Driver\LocalDriver->createFile" function uses "canonicalizeAndCheckFileIdentifier()" to make sure, that filenames are always converted to lower case, if the file system is not configured as case sensitive (see https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/core/Classes/Resource/Driver/AbstractHierarchicalFilesystemDriver.php#L91)

This sanitation seems to be missing for the creation of new folders in FAL. In order to make new file- and folder-creation consistent, both actions should take the "Uses case sensitive identifiers" setting into account and convert file-/foldernames to lowercase, if the setting is not checked.

Actions #2

Updated by Gerrit Code Review over 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59880

Actions #3

Updated by Gerrit Code Review over 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59880

Actions #4

Updated by Gerrit Code Review over 5 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59931

Actions #5

Updated by Anonymous over 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Gerrit Code Review over 5 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60578

Actions #7

Updated by Gerrit Code Review over 5 years ago

Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60578

Actions #8

Updated by Anonymous over 5 years ago

  • Status changed from Under Review to Resolved
Actions #9

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF