Bug #85603
closedDrag-and-drop content element results in page title in DataHandler command map instead of page UID
100%
Description
The JS lookup which detects the target page ID does a very loose lookup in the entire dom and catches what appears to be a page tree DOM element, then it reads the "data-page" attribute from it indiscriminately.
This causes two things:
- The DataHandler command map that is received contains the page title instead of the ID
- Anything that assumes an integer is provided and does casting, ends up with pid=1 which may not be a valid page and most likely is not the desired target page
While the surrounding code then fixes this (by simply ignoring this value...) it does mean that drag and drop does not work predictably in some DataHandler contexts (inability to read the actual page UID from anywhere).
Using the drop-target-relative parent's data attribute instead completely solves the problem. Does not affect 8.7.
Updated by Gerrit Code Review over 6 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57640
Updated by Gerrit Code Review over 6 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57640
Updated by Tymoteusz Motylewski over 6 years ago
- Sprint Focus set to On Location Sprint
Updated by Anja Leichsenring over 6 years ago
hi Claus, is it still possible to define a 'how-to-reproduce'? I don't get any page title upon any drag&drop action in page module. Might be my setup is too simple, so please help me out how to test?
Updated by Gerrit Code Review over 6 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57640
Updated by Anonymous over 6 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 62681cb0e1872e6f5e88c525547fa0e66d470ab8.