Bug #85608

Form editor does not save preselected values

Added by Ralf Zimmermann about 1 year ago. Updated 11 months ago.

Status:
Closed
Priority:
Must have
Category:
Form Framework
Start date:
2018-07-20
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

The validation of preselected values for the form elements "SingleSelect", "RadioButton", "MultiCheckbox" and "MultiSelect" fails on save if the "Selected" checkbox is checked within the "Choices" inspector editor.
Technically, the "Inspector-PropertyGridEditor" inspector editor JavaScript generates the additional property "defaultValue", which is not defined in the form setup.
The result is an exception on save like this

 #1297759968: No hmac found for property "defaultValue" (form element "singleselect-1") #1528588037

The form definition validation must take care about this special property.


Related issues

Related to TYPO3 Core - Bug #85670: Form Config throws exception on save after adding finishers or validators Closed 2018-07-27
Related to TYPO3 Core - Task #85673: Add form framework RequiredValidatorEditor test Closed 2018-07-29

Associated revisions

Revision 73536c1d (diff)
Added by Ralf Zimmermann about 1 year ago

[BUGFIX] Allow "defaultValue" for select form elements

Allows the form editor to save the property "defaultValue" for
"Inspector-PropertyGridEditor" inspector editors. This rules for the
form element types "SingleSelect", "RadioButton", "MultiCheckbox"
and "MultiSelect".

Besides that a flaw in JavaScript is solved that truncated values
by one character (e.g. having "propert" instead of "property"), as
well as having a correct representation of objects and arrays when
initializing them in JavaScript.

Resolves: #85608
Resolves: #85670
Releases: master, 8.7
Change-Id: Ia82ee236e6becb36db13fb15e96c7caceab370d1
Reviewed-on: https://review.typo3.org/57647
Reviewed-by: Oliver Hader <>
Tested-by: Oliver Hader <>
Tested-by: TYPO3com <>
Reviewed-by: Andreas Fernandez <>
Tested-by: Andreas Fernandez <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

Revision 3caf1224 (diff)
Added by Ralf Zimmermann about 1 year ago

[BUGFIX] Allow "defaultValue" for select form elements

Allows the form editor to save the property "defaultValue" for
"Inspector-PropertyGridEditor" inspector editors. This rules for the
form element types "SingleSelect", "RadioButton", "MultiCheckbox"
and "MultiSelect".

Besides that a flaw in JavaScript is solved that truncated values
by one character (e.g. having "propert" instead of "property"), as
well as having a correct representation of objects and arrays when
initializing them in JavaScript.

Resolves: #85608
Resolves: #85670
Releases: master, 8.7
Change-Id: Ia82ee236e6becb36db13fb15e96c7caceab370d1
Reviewed-on: https://review.typo3.org/57709
Tested-by: TYPO3com <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

Revision 55b3842a (diff)
Added by Oliver Hader about 1 year ago

[TASK] Add form framework RequiredValidatorEditor test

Resolves: #85673
Related: #85608
Releases: master, 8.7
Change-Id: If351dd316c628450e09e579d0cccbe7a7cefe213
Reviewed-on: https://review.typo3.org/57712
Tested-by: TYPO3com <>
Reviewed-by: Susanne Moog <>
Tested-by: Susanne Moog <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

Revision f43956de (diff)
Added by Oliver Hader about 1 year ago

[TASK] Add form framework RequiredValidatorEditor test

Resolves: #85673
Related: #85608
Releases: master, 8.7
Change-Id: If351dd316c628450e09e579d0cccbe7a7cefe213
Reviewed-on: https://review.typo3.org/57716
Tested-by: TYPO3com <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

Revision d197d70b (diff)
Added by Ralf Zimmermann about 1 year ago

[BUGFIX] Allow "defaultValue" for select form elements

Allows the form editor to save the property "defaultValue" for
"Inspector-PropertyGridEditor" inspector editors. This rules for the
form element types "SingleSelect", "RadioButton", "MultiCheckbox"
and "MultiSelect".

Besides that a flaw in JavaScript is solved that truncated values
by one character (e.g. having "propert" instead of "property"), as
well as having a correct representation of objects and arrays when
initializing them in JavaScript.

Resolves: #85608
Resolves: #85670
Releases: master, 8.7
Change-Id: Ia82ee236e6becb36db13fb15e96c7caceab370d1
Reviewed-on: https://review.typo3.org/57728
Reviewed-by: Oliver Hader <>
Tested-by: Oliver Hader <>

History

#1 Updated by Gerrit Code Review about 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57647

#2 Updated by Gerrit Code Review about 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57647

#3 Updated by Oliver Hader about 1 year ago

  • Target version set to 7.6.31 & 8.7.18 & 9.3.3

#4 Updated by Gerrit Code Review about 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57647

#5 Updated by Gerrit Code Review about 1 year ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57647

#6 Updated by Helmut Hummel about 1 year ago

  • Subject changed from Form editor dont save preselected values to Form editor does not save preselected values

#7 Updated by Gerrit Code Review about 1 year ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57647

#8 Updated by Ralf Zimmermann about 1 year ago

  • Related to Bug #85670: Form Config throws exception on save after adding finishers or validators added

#9 Updated by Gerrit Code Review about 1 year ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57647

#10 Updated by Gerrit Code Review about 1 year ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57647

#11 Updated by Gerrit Code Review about 1 year ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57709

#12 Updated by Ralf Zimmermann about 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#13 Updated by Oliver Hader about 1 year ago

  • Related to Task #85673: Add form framework RequiredValidatorEditor test added

#14 Updated by Gerrit Code Review about 1 year ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch 9.3 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57728

#15 Updated by Ralf Zimmermann about 1 year ago

  • Status changed from Under Review to Resolved

#16 Updated by Benni Mack 11 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF