Project

General

Profile

Actions

Bug #85888

open

Wrong page order in info modul pageTS overview

Added by Joerg Kummer over 6 years ago. Updated 4 months ago.

Status:
Accepted
Priority:
Should have
Assignee:
-
Category:
Miscellaneous
Target version:
-
Start date:
2018-08-17
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Backend info modul for page TS configuration lists pages (which contains TSConf values) as a page tree supplied with further informations.
In some cases, the ordering for pages does not match the real ordering in pagetree.

How to reproduce

- You need some pages with some subpages 2-3 levels in at least one pagetree
- Add any page TS configuration text to at least two subpages (2 level)
- Add any page TS configuration text to at least two subpages (3 level), which parent pages (2 level) may not have page TS configuration
- Sort/move pages from same level (2 level) in page tree, where highest page uid is on top (lowest on bottom)

Expectation

You may expect the same order of pages like in your page tree.

Experience

Pages of same level (which contains TSConf values) are ordered correct, where pages of same level without TSConf values (but their subpages) are mixed in between or at the end of this level.

The same issue was also detected in template modul overview, and fixed within #81430
See InfoPageTyposcriptConfigController::setInPageArray andcompare with TypoScriptTemplateModuleController::setInPageArray, where it is solved.

This issues TYPO3 8.7 and 9.4


Files

pagetreeorderinfomodulpagets.png (103 KB) pagetreeorderinfomodulpagets.png Joerg Kummer, 2018-08-17 12:56
issue85888_ws_bug.png (266 KB) issue85888_ws_bug.png Joerg Kummer, 2018-09-07 12:25
Cattura1.png (14.3 KB) Cattura1.png Riccardo De Contardi, 2024-04-14 19:59
Cattura2.png (28.1 KB) Cattura2.png Riccardo De Contardi, 2024-04-14 19:59
Actions #1

Updated by Joerg Kummer over 6 years ago

Further more the field page.tsconfig_includes is not considered in this overview.
On it, to write a patch.

Actions #2

Updated by Gerrit Code Review over 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57959

Actions #3

Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57959

Actions #4

Updated by Gerrit Code Review about 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57959

Actions #5

Updated by Gerrit Code Review about 6 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57959

Actions #6

Updated by Joerg Kummer about 6 years ago

Entries from workspaces doesnt shows correctly

This will be fixed with pending patch

Actions #7

Updated by Gerrit Code Review about 6 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57959

Actions #8

Updated by Gerrit Code Review about 6 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57959

Actions #9

Updated by Gerrit Code Review about 6 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57959

Actions #10

Updated by Markus Klein over 5 years ago

  • Status changed from Under Review to New

Updated by Riccardo De Contardi 7 months ago

I think this is still reproducible on TYPO3 11.5.35

My test:

1) Create a tree of pages with the following structure:

All the pages and subpages have some TSConfig lines except "Test without TSConfig 3"

2) Visit Info > PageTSConfig

Result

It looks like the pages with TSConfig are showed first.

A similar test has been performed on TYPO3 12 with the same result.

Actions #12

Updated by Georg Ringer 4 months ago

  • Status changed from New to Accepted

still valid in v13,

issue partly solved with

Index: typo3/sysext/backend/Classes/Controller/PageTsConfig/PageTsConfigRecordsOverviewController.php
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/typo3/sysext/backend/Classes/Controller/PageTsConfig/PageTsConfigRecordsOverviewController.php b/typo3/sysext/backend/Classes/Controller/PageTsConfig/PageTsConfigRecordsOverviewController.php
--- a/typo3/sysext/backend/Classes/Controller/PageTsConfig/PageTsConfigRecordsOverviewController.php    
+++ b/typo3/sysext/backend/Classes/Controller/PageTsConfig/PageTsConfigRecordsOverviewController.php    
@@ -121,6 +121,7 @@
                     $queryBuilder->createNamedParameter(0, Connection::PARAM_INT)
                 )
             )
+            ->orderBy('sorting')
             ->executeQuery();

         $pageArray = [];

but as this doesn't use any page tree logic, it is still wrong

Actions

Also available in: Atom PDF