Bug #85914

Errors in L10nModeUpdater with "l10n_mode = exclude" in pages_language_overlay

Added by Mathias Brodala over 2 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2018-08-21
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Given a field in pages_language_overlay marked with 'l10n_mode' => 'exclude' the L10nModeUpdater fails to process all records when upgrading from TYPO3v7 to TYPO3v8. The error:

Child record was not processed

In our specific case the field media was marked as such since editors are not supposed to manage it in translations. (Notice that the field is actually never hidden, see #81348) When running the upgrade wizard, it constantly failed with the mentioned error message but in fact did get further by one record on each run.

While looking into this I noticed that the DataMapProcessor determines if 'l10n_mode' => 'exclude' is set for a field based on DataMapItem::getFromTableName() which is always pages for pages_language_overlay. Thus for the given example above $GLOBALS['TCA']['pages']['columns']['media']['l10n_mode'] is checked instead of $GLOBALS['TCA']['pages_language_overlay']['columns']['media']['l10n_mode'].

After moving the l10n_mode to the TCA of pages instead I noticed that this is reverted on the fly by TcaMigration::migratePageLocalizationDefinitions() which moves the l10n_mode back from pages to pages_language_overlay. So it looks like like it is in fact impossible to set l10n_mode for columns of pages/pages_language_overlay.

In the end the issue could be solved/worked around by dropping l10n_mode completely here but I think that's not how it's supposed to be.


Related issues

Related to TYPO3 Core - Bug #81314: doubled references upon related record changeClosed2017-05-23

Actions
#1

Updated by Oliver Hader over 2 years ago

  • Related to Bug #81314: doubled references upon related record change added
#2

Updated by Michael Stucki almost 2 years ago

  • Status changed from New to Resolved

This bug is a duplicate of #81314. Closing here...

#3

Updated by Benni Mack almost 2 years ago

  • Status changed from Resolved to Closed
#4

Updated by Gerrit Code Review over 1 year ago

  • Status changed from Closed to Under Review

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60722

#5

Updated by Michael Stucki over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#6

Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF