Project

General

Profile

Actions

Task #86054

closed

Slug Handling does not add config.linkVars

Added by Benni Mack over 5 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Link Handling, Site Handling & Routing
Target version:
Start date:
2018-08-31
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Related issues 3 (0 open3 closed)

Related to TYPO3 Core - Task #86048: Create URLs with typolink for pages with sitesClosed2018-08-31

Actions
Related to TYPO3 Core - Bug #91870: TYPO3 v. 10.4 Caching and Speaking URLsClosed2020-07-25

Actions
Related to TYPO3 Core - Bug #93343: Accessing non-translated page with strict language breaks all menusClosed2021-01-22

Actions
Actions #1

Updated by Gerrit Code Review over 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58097

Actions #2

Updated by Christian Kuhn over 5 years ago

  • Related to Task #86048: Create URLs with typolink for pages with sites added
Actions #3

Updated by Benni Mack over 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #4

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions #5

Updated by Torben Hansen about 3 years ago

I stumbled about a really hard to spot but serious issue regarding this change. When you use config.linkVars = L, then it is possible to globally override the target language of all links on a page by adding the L Parameter to the URL.

Example scenario: (TYPO3 9.5 - master)

  • Website has 2 languages (0 = DE and 1 = EN)
  • TYPO3 page cache is empty
  • Website is initially opened as https://website.tld/?L=1

Result:

  • The website is shown in german language (expected) but all links created by PageLinkBuilder will link to the english version of the target (not expected).

Removing the L parameter from config.linkVars resolved the problem.

Should the L parameter from GET vars really be taken into account for language settings in TYPO3 9.5+?

Actions #6

Updated by Torben Hansen about 3 years ago

  • Related to Bug #91870: TYPO3 v. 10.4 Caching and Speaking URLs added
Actions #7

Updated by Torben Hansen about 3 years ago

  • Related to Bug #93343: Accessing non-translated page with strict language breaks all menus added
Actions

Also available in: Atom PDF