Bug #86165

New upgrade wizards cannot be marked as undone

Added by Helmut Hummel about 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2018-09-06
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

UpgradeWizardsService marks wizards as done in the registry by using the identifier, not the class name of the wizard.
However listOfWizardsDoneInRegistry only checks for the class name, which causes markWizardUndoneInRegistry to fail, as it relies on this API.

Steps to reproduce:

  • Go to install, upgrade
  • Mark "Merge be_groups access rights from pages_language_overlay to pages" as undone

Expected result:
Wizard can be executed again

Actual result:
Wizard is still listed as done


Related issues

Related to TYPO3 Core - Bug #87156: Database row upgrade wizard can not be marked undone Closed 2018-12-14

Associated revisions

Revision 65070536 (diff)
Added by Helmut Hummel about 1 year ago

[BUGFIX] Use class name to mark upgrade wizards done

To make the registry for done wizards consistent and stay backwards
compatible once all upgrade wizards are converted to use the
new interface, always store the class name of the wizard
instead of its identifier in the registry.

Additionally we now add checks for valid identifiers
to all API methods that receive one.

Releases: master
Resolves: #86165
Change-Id: I402852c90f5a8d3d0a05bacbd961a4bb4cb86d1e
Reviewed-on: https://review.typo3.org/58197
Tested-by: TYPO3com <>
Reviewed-by: Susanne Moog <>
Tested-by: Susanne Moog <>
Reviewed-by: Wouter Wolters <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>

History

#1 Updated by Gerrit Code Review about 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58197

#2 Updated by Gerrit Code Review about 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58197

#3 Updated by Gerrit Code Review about 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58197

#4 Updated by Helmut Hummel about 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#5 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

#6 Updated by Alexander Stehlik 11 months ago

  • Related to Bug #87156: Database row upgrade wizard can not be marked undone added

Also available in: Atom PDF