Project

General

Profile

Actions

Task #86196

closed

Centralize ExpressionLanguage Registration via API

Added by Susanne Moog almost 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Code Cleanup
Target version:
Start date:
2018-09-07
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Currently Symfony ExpressionLanguage is used in two contexts:

- the form framework
- typoscript condition matching

registration and providing context is done in two different ways and is extensible in two different ways. Before the LTS release these should be unified and documented.

Tasks:
- Add Configuration/ExpressionLanguage.php and corresponding loader with caching


// Config

<?php

return [
    'conditions' => [
            \TYPO3\CMS\Core\ExpressionLanguage\Typo3ConditionProvider
    ],
    'ext-form' => [
            \TYPO3\CMS\Core\ExpressionLanguage\Typo3ConditionProvider,
            \TYPO3\CMS\Form\Domain\Condition\ConditionProvider
    ]
];

// Usage:
$expressionLanguage = new \TYPO3\CMS\Core\ExpressionLanguage\Resolver('ext-form');

- Load expressionLanguage via loader with context argument in form and conditionMatcher
- Remove yaml config in form


Related issues 3 (0 open3 closed)

Related to TYPO3 Core - Feature #84133: Variants - Frontend implementationClosedRalf Zimmermann2018-05-24

Actions
Related to TYPO3 Core - Bug #92471: condition contentObject["pid"] not working in variantClosed2020-10-02

Actions
Related to TYPO3 Core - Bug #97023: EXT:form - Outdated documentation of expression languageClosedElias Häußler2022-02-24

Actions
Actions #1

Updated by Susanne Moog almost 6 years ago

  • Description updated (diff)
Actions #2

Updated by Susanne Moog almost 6 years ago

  • Description updated (diff)
Actions #3

Updated by Susanne Moog almost 6 years ago

  • Description updated (diff)
Actions #4

Updated by Susanne Moog almost 6 years ago

  • Description updated (diff)
Actions #5

Updated by Susanne Moog almost 6 years ago

  • Description updated (diff)
Actions #6

Updated by Susanne Moog almost 6 years ago

  • Description updated (diff)
Actions #7

Updated by Benni Mack almost 6 years ago

just don't call it `ext-form` please. either "form" or form-framework. I'm for "form".

Also "typoscript-conditions"?

Because we're going to have "typoscript-if" and "tca-display-conditions" and maybe "routing"

Actions #8

Updated by Susanne Moog almost 6 years ago

  • Status changed from New to In Progress
  • Assignee set to Susanne Moog
Actions #9

Updated by Susanne Moog almost 6 years ago

@Benni Mack while building I noticed we don't have that many contexts. We should not distinguish TypoScript conditions and other scopes at all. In fact conditions are conditions. The TypoScript conditions basically provide TYPO3 conditions that should be usable in any context (extensions PHP code, typoscript, with an expression language viewhelper even in fluid) as the methods and vars provided there aren't specific to TypoScript.

We can talk about that again, I'll push the WIP now.

Actions #10

Updated by Susanne Moog almost 6 years ago

  • Description updated (diff)
Actions #11

Updated by Susanne Moog almost 6 years ago

  • Description updated (diff)
Actions #12

Updated by Gerrit Code Review almost 6 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58232

Actions #13

Updated by Gerrit Code Review almost 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58232

Actions #14

Updated by Susanne Moog almost 6 years ago

Actions #15

Updated by Gerrit Code Review almost 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58232

Actions #16

Updated by Gerrit Code Review almost 6 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58232

Actions #17

Updated by Gerrit Code Review almost 6 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58232

Actions #18

Updated by Gerrit Code Review almost 6 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58232

Actions #19

Updated by Gerrit Code Review almost 6 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58232

Actions #20

Updated by Gerrit Code Review almost 6 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58232

Actions #21

Updated by Gerrit Code Review over 5 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58232

Actions #22

Updated by Gerrit Code Review over 5 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58232

Actions #23

Updated by Gerrit Code Review over 5 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58232

Actions #24

Updated by Gerrit Code Review over 5 years ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58232

Actions #25

Updated by Gerrit Code Review over 5 years ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58232

Actions #26

Updated by Gerrit Code Review over 5 years ago

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58232

Actions #27

Updated by Gerrit Code Review over 5 years ago

Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58232

Actions #28

Updated by Gerrit Code Review over 5 years ago

Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58232

Actions #29

Updated by Gerrit Code Review over 5 years ago

Patch set 17 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58232

Actions #30

Updated by Gerrit Code Review over 5 years ago

Patch set 18 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58232

Actions #31

Updated by Gerrit Code Review over 5 years ago

Patch set 19 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58232

Actions #32

Updated by Gerrit Code Review over 5 years ago

Patch set 20 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58232

Actions #33

Updated by Gerrit Code Review over 5 years ago

Patch set 21 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58232

Actions #34

Updated by Gerrit Code Review over 5 years ago

Patch set 22 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58232

Actions #35

Updated by Gerrit Code Review over 5 years ago

Patch set 23 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58232

Actions #36

Updated by Gerrit Code Review over 5 years ago

Patch set 24 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58232

Actions #37

Updated by Gerrit Code Review over 5 years ago

Patch set 25 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58232

Actions #38

Updated by Gerrit Code Review over 5 years ago

Patch set 26 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58232

Actions #39

Updated by Gerrit Code Review over 5 years ago

Patch set 27 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58232

Actions #40

Updated by Gerrit Code Review over 5 years ago

Patch set 28 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58232

Actions #41

Updated by Gerrit Code Review over 5 years ago

Patch set 29 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58232

Actions #42

Updated by Gerrit Code Review over 5 years ago

Patch set 30 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58232

Actions #43

Updated by Gerrit Code Review over 5 years ago

Patch set 31 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58232

Actions #44

Updated by Gerrit Code Review over 5 years ago

Patch set 32 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58232

Actions #45

Updated by Susanne Moog over 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #46

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions #47

Updated by Christian Kuhn about 3 years ago

  • Related to Bug #92471: condition contentObject["pid"] not working in variant added
Actions #48

Updated by Elias Häußler over 2 years ago

  • Related to Bug #97023: EXT:form - Outdated documentation of expression language added
Actions

Also available in: Atom PDF