Task #86270

Epic #83968: PSR-11 Initiative

Deprecate config.tx_extbase.objects and plugin.tx_%name%.objects

Added by Benjamin Franzke about 1 year ago. Updated 5 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Extbase
Target version:
-
Start date:
2018-09-16
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

If we want to introduce a system wide container in v10,
the non deterministic behaviour of object (re)configurations
during runtime in extbase will be a problem.
Compiled containers like symfony DI do not allow runtime
reconfigurations.

Also the concept of per plugin overwrites is broken anyway,
and should therefore be dropped:
The "objects" configured through plugin.tx_%name%.objects
are are never reset, that means:
Plugin A might overwrite an object and plugin B will implictly use
that overriden class, despite not having configured that at all.
(depending on the fact whether plugin A is rendered before or not)


Related issues

Related to TYPO3 Core - Bug #86290: Suggested migration regarding config.tx_extbase.objects does not work for Models mapped using the PropertyMapper Closed 2018-09-18
Related to TYPO3 Core - Bug #76902: Method signature parameters raises a Warning with config.tx_extbase.objects.TYPO3\CMS\Extbase\Persistence\Generic\Mapper\ColumnMap.className = Foo\Bar\Zoo Closed 2016-07-01

Associated revisions

Revision 292e300b (diff)
Added by Benjamin Franzke about 1 year ago

[TASK] Deprecate config.tx_extbase.objects and plugin.tx_%name%.objects

If we want to introduce a system wide container in v10,
the non deterministic behaviour of object (re)configurations
during runtime in extbase will be a problem.
Compiled containers like symfony DI do not allow runtime
reconfigurations.

Also the concept of per plugin overwrites is broken anyway,
and should therefore be dropped:
The "objects" configured through plugin.tx_%name%.objects
are are never reset, that means:
Plugin A might overwrite an object and plugin B will implictly use
that overriden class, despite not having configured that at all.
(depending on the fact whether plugin A is rendered before or not)

config.tx_extbase.object class overwrites can be replaced by XCLASSes.
If config.tx_extbase.object was/is used to conditionally overwrite
classes (through sys_template or conditions), these
occasions should be changed to XCLASSes as well. In that case the
conditional overwrite needs to be moved into the xclass itself.

Change-Id: I2ef839bcbb7f941c3afa0010767560d20e15f98b
Releases: master
Resolves: #86270
Reviewed-on: https://review.typo3.org/58288
Reviewed-by: Andreas Fernandez <>
Tested-by: Andreas Fernandez <>
Tested-by: TYPO3com <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

Revision ae232d88 (diff)
Added by Benjamin Franzke about 1 year ago

[BUGFIX] Add more migration hints for config.tx_extbase.objects

The suggested migration (xclasses) does not work for Models
mapped using the PropertyMapper.
It also fails if additional injections have been configured.
(though that could be fixed using
`GeneralUtility::makeInstance(ObjectManager::class)->get()`)

Change-Id: If22b98526fce575435662e731a4f2efca9a014f3
Releases: master
Resolves: #86290
Related: #86270
Reviewed-on: https://review.typo3.org/58310
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Tested-by: TYPO3com <>
Reviewed-by: Andreas Fernandez <>
Tested-by: Andreas Fernandez <>

History

#1 Updated by Gerrit Code Review about 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58288

#2 Updated by Gerrit Code Review about 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58288

#3 Updated by Gerrit Code Review about 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58288

#4 Updated by Gerrit Code Review about 1 year ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58288

#5 Updated by Benjamin Franzke about 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Christian Kuhn about 1 year ago

  • Related to Bug #86290: Suggested migration regarding config.tx_extbase.objects does not work for Models mapped using the PropertyMapper added

#7 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

#8 Updated by Georg Ringer 8 months ago

  • Related to Bug #76902: Method signature parameters raises a Warning with config.tx_extbase.objects.TYPO3\CMS\Extbase\Persistence\Generic\Mapper\ColumnMap.className = Foo\Bar\Zoo added

#9 Updated by Benjamin Franzke 5 months ago

  • Parent task set to #83968

Also available in: Atom PDF