Bug #86315

Modal.show() does not pass severity

Added by Andreas Fernandez about 1 year ago. Updated 12 months ago.

Status:
Closed
Priority:
Should have
Category:
Backend User Interface
Target version:
Start date:
2018-09-19
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

Modal.show() accepts a severity parameter. However, the parameter is not passed to advanced(), thus the parameter is ignored.


Related issues

Related to TYPO3 Core - Task #82596: EXT:backend Modal.js Closed 2017-09-28
Related to TYPO3 Core - Bug #86316: Set correct severity for paste modal in page module Closed 2018-09-19

Associated revisions

Revision c26c272b (diff)
Added by Andreas Fernandez about 1 year ago

[BUGFIX] Use passed severity for modal construction

The `severity` parameter must be passed to `advanced()` to have a proper
styling of the modal header.

Resolves: #86315
Related: #82596
Releases: master
Change-Id: I8904700198fd2ac6d5a0ac7817c3232cc84da4d1
Reviewed-on: https://review.typo3.org/58333
Reviewed-by: Mathias Brodala <>
Reviewed-by: Josef Glatz <>
Tested-by: Josef Glatz <>
Tested-by: TYPO3com <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

History

#1 Updated by Andreas Fernandez about 1 year ago

#2 Updated by Gerrit Code Review about 1 year ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58333

#3 Updated by Josef Glatz about 1 year ago

  • Related to Bug #86316: Set correct severity for paste modal in page module added

#4 Updated by Andreas Fernandez about 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#5 Updated by Benni Mack 12 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF