Task #82596

Epic #82577: Migrate all JavaScript to TypeScript

EXT:backend Modal.js

Added by Frank Naegler about 2 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend JavaScript
Target version:
Start date:
2017-09-28
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Related issues

Related to TYPO3 Core - Bug #84138: Repetitive creation of content elements via wizard not possible anymore Closed 2018-03-05
Related to TYPO3 Core - Bug #86315: Modal.show() does not pass severity Closed 2018-09-19
Related to TYPO3 Core - Bug #89253: Modal loadUrl not usable Resolved 2019-09-24

Associated revisions

Revision dd06aba8 (diff)
Added by Andreas Fernandez over 1 year ago

[TASK] Migrate Modal to TypeScript

Change-Id: Ic71a3dde434402ad828e2098eefae80f4039475b
Resolves: #82596
Releases: master
Reviewed-on: https://review.typo3.org/55847
Tested-by: TYPO3com <>
Reviewed-by: Frank Naegler <>
Tested-by: Frank Naegler <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

Revision c26c272b (diff)
Added by Andreas Fernandez about 1 year ago

[BUGFIX] Use passed severity for modal construction

The `severity` parameter must be passed to `advanced()` to have a proper
styling of the modal header.

Resolves: #86315
Related: #82596
Releases: master
Change-Id: I8904700198fd2ac6d5a0ac7817c3232cc84da4d1
Reviewed-on: https://review.typo3.org/58333
Reviewed-by: Mathias Brodala <>
Reviewed-by: Josef Glatz <>
Tested-by: Josef Glatz <>
Tested-by: TYPO3com <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

Revision 3b6e94ee (diff)
Added by Frank Naegler about 1 month ago

[BUGFIX] Make Modal.loadUrl working again

With the migration to TypeScript (#82596) a regression was merged.
This patch fix the broken loadUrl method of the Modal module.

Resolves: #89253
Related: #82596
Releases: master, 9.5
Change-Id: Id84a0a2a6299daca819ef0304678a6ab25b5955b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61935
Tested-by: TYPO3com <>
Tested-by: Tobi Kretschmann <>
Tested-by: Andreas Fernandez <>
Reviewed-by: Kevin Ditscheid <>
Reviewed-by: Sascha Rademacher <>
Reviewed-by: Tobi Kretschmann <>
Reviewed-by: Julian Geils <>
Reviewed-by: Daniel Goerz <>
Reviewed-by: Andreas Fernandez <>

Revision 488b53e8 (diff)
Added by Frank Naegler about 1 month ago

[BUGFIX] Make Modal.loadUrl working again

With the migration to TypeScript (#82596) a regression was merged.
This patch fixes the broken loadUrl method of the Modal module.

Resolves: #89253
Related: #82596
Releases: master, 9.5
Change-Id: Id84a0a2a6299daca819ef0304678a6ab25b5955b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61936
Tested-by: Andreas Fernandez <>
Tested-by: TYPO3com <>
Reviewed-by: Andreas Fernandez <>

History

#1 Updated by Riccardo De Contardi about 2 years ago

  • Category set to Backend JavaScript

#2 Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55847

#3 Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55847

#4 Updated by Gerrit Code Review over 1 year ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55847

#5 Updated by Gerrit Code Review over 1 year ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55847

#6 Updated by Gerrit Code Review over 1 year ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55847

#7 Updated by Gerrit Code Review over 1 year ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55847

#8 Updated by Gerrit Code Review over 1 year ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55847

#9 Updated by Andreas Fernandez over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#10 Updated by Andreas Fernandez over 1 year ago

  • Related to Bug #84138: Repetitive creation of content elements via wizard not possible anymore added

#11 Updated by Andreas Fernandez about 1 year ago

  • Related to Bug #86315: Modal.show() does not pass severity added

#12 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

#13 Updated by Frank Naegler about 1 month ago

  • Related to Bug #89253: Modal loadUrl not usable added

Also available in: Atom PDF