Bug #86553

Workspaces stagin action change fatal error.

Added by Andriy Khamuliak 9 months ago. Updated about 1 month ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Link Handling, Site Handling & Routing
Target version:
Start date:
2018-10-03
Due date:
% Done:

0%

TYPO3 Version:
9
PHP Version:
7.2
Tags:
Complexity:
Is Regression:
Sprint Focus:
On Location Sprint

Description

Function buildUriForWorkspaceSplitPreview of TYPO3\CMS\Workspaces\Preview\PreviewUriBuilder throws fatal error if called with $addDomain = true

at line

    return BackendUtility::getViewDomain($uid) . 'index.php?redirect_url=' . urlencode($viewScript);

Which says that urlencode must have string as argument and not an object.

I assume this line must be changed to

    return BackendUtility::getViewDomain($uid) . 'index.php?redirect_url=' . urlencode((string)$viewScript);

as we have at sting below in $addDomain = false case.

Workspaces staging action change are not working because of it.

After that change performed form can be submitted and mails are send, but markers

'###PREVIEW_LINK###'] and ['###SPLITTED_PREVIEW_LINK###'] are wrongly rendered with TYPO3\CMS\Workspaces\Preview\PreviewUriBuilder

it still uses old style URLs and preview link f.e. looks like:

http://example.com/index.php?&ADMCMD_prev=7fd5c4d6dc9a382aebf001dc32b781ec&id=12

Which causes 404 Page Not Found status.

if manually change url to speaking one and add generated ADMCMD argument all works fine.

History

#1 Updated by Georg Ringer 9 months ago

  • Category changed from Workspaces to Link Handling, Site Handling & Routing

#2 Updated by Susanne Moog 8 months ago

  • Sprint Focus set to On Location Sprint

#3 Updated by Andreas Fernandez 6 months ago

  • Status changed from New to Resolved

Issue has been resolved with #86928, so I'll close this ticket now.

#4 Updated by Benni Mack about 1 month ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF