Bug #87107
closedRemove phpunit-randomizer from dependencies
100%
Description
Since phpunit/phpunit version 7.4 the package contains an own randomizer option (order-by).
See https://github.com/fiunchinho/phpunit-randomizer, the ReadMe features a broken link even to phpunit 7.3, but it is not in the docs for this version.
I tested, and the last version working with `bin/phpunit-randomizer -c vendor/typo3/testing-framework/Resources/Core/Build/UnitTests.xml --order rand` would be phpunit 7.2.
With the latest test run, the randomizer call used by the nightly run even fails. The used phpunit version was 7.5 (released yesterday)
The day before, the nighly run used phpunit 7.1 as max version, no error was detected.
So here is my conclusion:
- quickfix would be to limit the max phpunit version to 7.2
- extend the test specs to detect which phpunit version is used, make the randomizer all until 7.2, above use phpunit with `order-by=random`.
- remove the fiunchinho/phpunit-randomizer package from the deps
- drop dependency phpunit <7.3.
Updated by Gerrit Code Review over 5 years ago
- Status changed from New to Under Review
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59823
Updated by Gerrit Code Review over 5 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59823
Updated by Christian Kuhn over 5 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset f74cf58c1daff84e14e41d73074ad8e6e64bd46e.
Updated by Gerrit Code Review over 5 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59831
Updated by Christian Kuhn over 5 years ago
- Status changed from Under Review to Resolved
Applied in changeset 039c786c6625b7f0600fae494ea441b68153875d.