Project

General

Profile

Actions

Bug #87107

closed

Remove phpunit-randomizer from dependencies

Added by Anja Leichsenring almost 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2018-12-08
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Since phpunit/phpunit version 7.4 the package contains an own randomizer option (order-by).

See https://github.com/fiunchinho/phpunit-randomizer, the ReadMe features a broken link even to phpunit 7.3, but it is not in the docs for this version.
I tested, and the last version working with `bin/phpunit-randomizer -c vendor/typo3/testing-framework/Resources/Core/Build/UnitTests.xml --order rand` would be phpunit 7.2.

With the latest test run, the randomizer call used by the nightly run even fails. The used phpunit version was 7.5 (released yesterday)

The day before, the nighly run used phpunit 7.1 as max version, no error was detected.

So here is my conclusion:
- quickfix would be to limit the max phpunit version to 7.2

- extend the test specs to detect which phpunit version is used, make the randomizer all until 7.2, above use phpunit with `order-by=random`.
- remove the fiunchinho/phpunit-randomizer package from the deps
- drop dependency phpunit <7.3.

Actions #1

Updated by Gerrit Code Review over 5 years ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59823

Actions #2

Updated by Gerrit Code Review over 5 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59823

Actions #3

Updated by Christian Kuhn over 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #4

Updated by Gerrit Code Review over 5 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59831

Actions #5

Updated by Christian Kuhn over 5 years ago

  • Status changed from Under Review to Resolved
Actions #6

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF