Bug #87375

Proper exception messages for Scheduler::fetchTask()

Added by Stefanos Karasavvidis 13 days ago. Updated 1 day ago.

Status:
Under Review
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2019-01-09
Due date:
% Done:

0%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The method Scheduler::fetchTask() takes an optional uid as argument. If the uid is given, the task with this uid should be returned.

If no uid is given, the next scheduled overdue task should be returned (the method description says "the next due task", but what is implemented is the next task that is overdue).

A) If a uid is given but this uid does not exist, an exception with the misleading message 'Query could not be executed. Possible defect in tables tx_scheduler_task or tx_scheduler_task_group or DB server problems' is thrown.

B) If no uid is given, and no task is overdue, an exception is thrown. The current code tries to use as message "No task". But this part is never reached.

A) should be fixed to a proper message, like "no such task"

B) is never reached because the check for A precedes it and evaluates to true even for case B.

History

#1 Updated by Stefanos Karasavvidis 13 days ago

B) is never reached because the check for A precedes it and evaluates to true even for case A.

To make this clearer: if no uid is passed to the method, and no task is overdue, again the 'Query could not be executed. Possible defect in tables tx_scheduler_task or tx_scheduler_task_group or DB server problems' message is used in the exception

#2 Updated by Gerrit Code Review 13 days ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59385

#3 Updated by Gerrit Code Review 13 days ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59385

#4 Updated by Gerrit Code Review 2 days ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59385

#5 Updated by Gerrit Code Review 2 days ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59385

#6 Updated by Gerrit Code Review 1 day ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59385

Also available in: Atom PDF