Bug #87375
closed
Proper exception messages for Scheduler::fetchTask()
100%
Description
The method Scheduler::fetchTask() takes an optional uid as argument. If the uid is given, the task with this uid should be returned.
If no uid is given, the next scheduled overdue task should be returned (the method description says "the next due task", but what is implemented is the next task that is overdue).
A) If a uid is given but this uid does not exist, an exception with the misleading message 'Query could not be executed. Possible defect in tables tx_scheduler_task or tx_scheduler_task_group or DB server problems' is thrown.
B) If no uid is given, and no task is overdue, an exception is thrown. The current code tries to use as message "No task". But this part is never reached.
A) should be fixed to a proper message, like "no such task"
B) is never reached because the check for A precedes it and evaluates to true even for case B.
Updated by Stefanos Karasavvidis over 5 years ago
B) is never reached because the check for A precedes it and evaluates to true even for case A.
To make this clearer: if no uid is passed to the method, and no task is overdue, again the 'Query could not be executed. Possible defect in tables tx_scheduler_task or tx_scheduler_task_group or DB server problems' message is used in the exception
Updated by Gerrit Code Review over 5 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59385
Updated by Gerrit Code Review over 5 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59385
Updated by Gerrit Code Review over 5 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59385
Updated by Gerrit Code Review over 5 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59385
Updated by Gerrit Code Review over 5 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59385
Updated by
Updated by Gerrit Code Review about 5 years ago
Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59613
Updated by Gerrit Code Review about 5 years ago
Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59614
Updated by Stefanos Karasavvidis about 5 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 08295e09d86603ab6121ac7732dae0361e564bea.
Updated by Benni Mack almost 5 years ago
- Status changed from Resolved to Closed