Bug #87390
closedView Upgrade Documentation: ordering mixed (wrong sorting)
100%
Description
Updated by Georg Ringer over 4 years ago
- Status changed from Accepted to Needs Feedback
can you pls recheck if still valid in 10, imo fixed
Updated by Georg Ringer over 4 years ago
- Related to Bug #88883: Wrong sorting in documentation changelog added
Updated by Josef Glatz over 4 years ago
- Subject changed from View Upgrade Documentation: ordering mixed to View Upgrade Documentation: ordering mixed (wrong sorting)
Nope, not fixed in 9.5 or master as of today¶
Affected TYPO3 versions: 9.5 and master (10)
until TYPO3 8.7 the rST's itself where sorted by "severity". Beginning with Breaking
, ... and so on
By looking into the code I think the right position is in \TYPO3\CMS\Install\UpgradeAnalysis\DocumentationFile::getDocumentationFilesForVersion
¶
/**
* Handle a single directory
*
* @param string $docDirectory
* @return array
*/
protected function getDocumentationFilesForVersion(string $docDirectory): array
{
$documentationFiles = [[]];
$absolutePath = str_replace('\\', '/', $docDirectory);
$finder = $this->getDocumentFinder()->in($absolutePath);
foreach ($finder->files() as $file) {
/** @var SplFileInfo $file */
$documentationFiles[] = $this->getListEntry($file->getPathname());
}
return array_merge(...$documentationFiles);
}
Maybe it's the right area to sort by class
subarray value. The "class
" subarray value holds values like feature
.
Updated by Gerrit Code Review over 4 years ago
- Status changed from Needs Feedback to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63913
Updated by Gerrit Code Review over 4 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63913
Updated by Gerrit Code Review over 4 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63913
Updated by Gerrit Code Review over 4 years ago
Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63894
Updated by Anonymous over 4 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset ed216f78bf6a13b81f7dab81b720df5423b68a08.