Task #87394

composer gerrit:setup should be available for all platforms

Added by Sybille Peters 11 months ago. Updated 11 months ago.

Status:
New
Priority:
Should have
Assignee:
Category:
-
Target version:
-
Start date:
2019-01-11
Due date:
% Done:

0%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

I am currently updating the Contribution Guide. I would like to simplify the setup.

composer gerrit:setup sets up both commit hooks: commit-msg and pre-commit. The pre-commit hook currently may not run on Windows.

For this reason, you can't just write: just run composer gerrit:setup to setup commit hooks. You have to write: for windows do ..., for Linux / Mac do ...

So, it might be useful to do one of the following:

  1. make the pre-commit hook portable
  2. only copy the commit-msg hook with gerrit:setup
  3. or check before copying if it will run on current system in InstallerScripts:enablePreCommitHook

History

#1 Updated by Josef Glatz 11 months ago

  • Assignee set to Josef Glatz

Also available in: Atom PDF