Project

General

Profile

Actions

Bug #87430

closed

Fields which are not required render with required attribute

Added by Jarvis H almost 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Form Framework
Target version:
-
Start date:
2019-01-14
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
9
PHP Version:
7.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

A text field will render with the required attribute even though the "required" setting is not present in the yaml config.

How to reproduce:

Create a form with two text fields, the first set to "required" (see yaml config below).

The required field must be positioned before the non-required field, if it is not the bug does not occur.

Expected outcome:

Only the first field should be required.

Actual outcome

Both fields are set to required, where the second field also has the "required" attribute, but not the label indicator (see attached screenshot).

Suspected cause
The formvh:translateElementProperty viewhelper


renderingOptions:
  submitButtonLabel: Submit
type: Form
identifier: test
label: Test
prototypeName: standard
renderables:
  -
    renderingOptions:
      previousButtonLabel: 'Previous step'
      nextButtonLabel: 'Neue Seite'
    type: Page
    identifier: page-1
    label: Step
    renderables:
      -
        defaultValue: ''
        type: Text
        identifier: text-1
        label: 'Required field'
        validators:
          -
            identifier: NotEmpty
        properties:
          fluidAdditionalAttributes:
            required: required
      -
        defaultValue: ''
        type: Text
        identifier: text-2
        label: 'Not required field'


Files

field_required.png (137 KB) field_required.png Jarvis H, 2019-01-14 16:01

Related issues 1 (0 open1 closed)

Is duplicate of TYPO3 Core - Bug #86890: AbstractTagBasedViewHelper recycles the TagBuilderClosed2018-11-08

Actions
Actions #1

Updated by Jarvis H almost 6 years ago

Just realized this was already reported here: https://forge.typo3.org/issues/86890

This issue can be closed

Actions #2

Updated by Josef Glatz almost 6 years ago

  • Is duplicate of Bug #86890: AbstractTagBasedViewHelper recycles the TagBuilder added
Actions #3

Updated by Josef Glatz almost 6 years ago

  • Status changed from New to Closed

Thanks for the update Jarvis!

Actions #4

Updated by Gerrit Code Review almost 6 years ago

  • Status changed from Closed to Under Review

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59554

Actions #5

Updated by Gerrit Code Review almost 6 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59554

Actions #6

Updated by Gerrit Code Review almost 6 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59554

Actions #7

Updated by Gerrit Code Review almost 6 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59609

Actions #8

Updated by Gerrit Mohrmann almost 6 years ago

  • Status changed from Under Review to Resolved
Actions #9

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF