Bug #87430

Fields which are not required render with required attribute

Added by Jarvis H 4 months ago. Updated 18 days ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Form Framework
Target version:
-
Start date:
2019-01-14
Due date:
% Done:

0%

TYPO3 Version:
9
PHP Version:
7.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

A text field will render with the required attribute even though the "required" setting is not present in the yaml config.

How to reproduce:

Create a form with two text fields, the first set to "required" (see yaml config below).

The required field must be positioned before the non-required field, if it is not the bug does not occur.

Expected outcome:

Only the first field should be required.

Actual outcome

Both fields are set to required, where the second field also has the "required" attribute, but not the label indicator (see attached screenshot).

Suspected cause
The formvh:translateElementProperty viewhelper


renderingOptions:
  submitButtonLabel: Submit
type: Form
identifier: test
label: Test
prototypeName: standard
renderables:
  -
    renderingOptions:
      previousButtonLabel: 'Previous step'
      nextButtonLabel: 'Neue Seite'
    type: Page
    identifier: page-1
    label: Step
    renderables:
      -
        defaultValue: ''
        type: Text
        identifier: text-1
        label: 'Required field'
        validators:
          -
            identifier: NotEmpty
        properties:
          fluidAdditionalAttributes:
            required: required
      -
        defaultValue: ''
        type: Text
        identifier: text-2
        label: 'Not required field'

field_required.png View (137 KB) Jarvis H, 2019-01-14 16:01


Related issues

Duplicates TYPO3 Core - Bug #86890: AbstractTagBasedViewHelper recycles the TagBuilder Closed 2018-11-08

Associated revisions

Revision 3469afec (diff)
Added by Gerrit Mohrmann 4 months ago

[TASK] Update typo3fluid/fluid to 2.6.0

Fixes missing output in ifAuthenticatedViewHelper after cache clearing
and erroneous replication of field properties to subsequent fields.

composer command used:
composer update typo3fluid/fluid

Resolves: #86930
Resolves: #86890
Resolves: #87430
Resolves: #86910
Resolves: #87586
Releases: master, 9.5
Change-Id: I8d1abd0aa08d7d7399ec23675dcf07d08dbdd2f2
Reviewed-on: https://review.typo3.org/59554
Tested-by: TYPO3com <>
Reviewed-by: Jonas Eberle <>
Tested-by: Jonas Eberle <>
Reviewed-by: Oliver Klee <>
Reviewed-by: Andreas Fernandez <>
Reviewed-by: Mona Muzaffar <>
Tested-by: Mona Muzaffar <>
Tested-by: Andreas Fernandez <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>

Revision 3ee1346a (diff)
Added by Gerrit Mohrmann 4 months ago

[TASK] Update typo3fluid/fluid to 2.6.0

Fixes missing output in ifAuthenticatedViewHelper after cache clearing
and erroneous replication of field properties to subsequent fields.

composer command used:
composer update typo3fluid/fluid

Resolves: #86930
Resolves: #86890
Resolves: #87430
Resolves: #86910
Resolves: #87586
Releases: master, 9.5
Change-Id: I8d1abd0aa08d7d7399ec23675dcf07d08dbdd2f2
Reviewed-on: https://review.typo3.org/59609
Tested-by: TYPO3com <>
Reviewed-by: Mona Muzaffar <>
Tested-by: Mona Muzaffar <>
Reviewed-by: Susanne Moog <>
Tested-by: Susanne Moog <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>

History

#1 Updated by Jarvis H 4 months ago

Just realized this was already reported here: https://forge.typo3.org/issues/86890

This issue can be closed

#2 Updated by Josef Glatz 4 months ago

  • Duplicates Bug #86890: AbstractTagBasedViewHelper recycles the TagBuilder added

#3 Updated by Josef Glatz 4 months ago

  • Status changed from New to Closed

Thanks for the update Jarvis!

#4 Updated by Gerrit Code Review 4 months ago

  • Status changed from Closed to Under Review

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59554

#5 Updated by Gerrit Code Review 4 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59554

#6 Updated by Gerrit Code Review 4 months ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59554

#7 Updated by Gerrit Code Review 4 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59609

#8 Updated by Gerrit Mohrmann 4 months ago

  • Status changed from Under Review to Resolved

#9 Updated by Benni Mack 18 days ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF