Bug #87712

stdWrap.lang does not use Site Handling

Added by Benni Mack 3 days ago. Updated 1 day ago.

Status:
Resolved
Priority:
Should have
Assignee:
Category:
Link Handling, Site Handling & Routing
Target version:
Start date:
2019-02-14
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

If you do

10 = TEXT
10.value = English
10.lang.de = German

this does not work, as this still relies on ugly TypoScript settings.

Associated revisions

Revision b898fc08 (diff)
Added by Benni Mack 1 day ago

[BUGFIX] Have stdWrap.lang use Site concept

When building TypoScript like this:

10 = TEXT
10.value = English
10.lang.dk = danish

This does not work currently as it relies on "config.language". This part
has been forgotten while the Site Handling was initially implemented into
the TYPO3 core.

The patch adapts the changes to make use of Site Handling if it is available,
but falls back to the TypoScript options (for PseudoSites).

Resolves: #87712
Releases: master, 9.5
Change-Id: I5e2b97b178e6ccafec1ff7556d41321ea67fb45a
Reviewed-on: https://review.typo3.org/59698
Tested-by: TYPO3com <>
Reviewed-by: Daniel Goerz <>
Tested-by: Daniel Goerz <>
Reviewed-by: Jörg Bösche <>
Reviewed-by: Josef Glatz <>
Tested-by: Josef Glatz <>
Reviewed-by: Georg Ringer <>
Tested-by: Georg Ringer <>

Revision 91898b9d (diff)
Added by Benni Mack 1 day ago

[BUGFIX] Have stdWrap.lang use Site concept

When building TypoScript like this:

10 = TEXT
10.value = English
10.lang.dk = danish

This does not work currently as it relies on "config.language". This part
has been forgotten while the Site Handling was initially implemented into
the TYPO3 core.

The patch adapts the changes to make use of Site Handling if it is available,
but falls back to the TypoScript options (for PseudoSites).

Resolves: #87712
Releases: master, 9.5
Change-Id: I5e2b97b178e6ccafec1ff7556d41321ea67fb45a
Reviewed-on: https://review.typo3.org/59704
Tested-by: TYPO3com <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

History

#1 Updated by Gerrit Code Review 3 days ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59698

#2 Updated by Gerrit Code Review 2 days ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59698

#3 Updated by Gerrit Code Review 2 days ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59698

#4 Updated by Sven Juergens 2 days ago

Hi Benni,

your Patch ist not working with this example:

10 = TEXT
10.value = german
10.lang.en = english

In your patch you use
$currentLanguageCode = $siteLanguage->getTypo3Language();

but for "en" this code give back "default"

maybe you can use
"$siteLanguage->getTwoLetterIsoCode()"

?

Best Regards
Sven

#5 Updated by Benni Mack 2 days ago

hey Sven,

good question. Before, this TypoScript option was set to config.language = default (= loading XLF files with "default" language), so config.language = en was wrong actually as "en" never existed, so it "fell back" to default.

#6 Updated by Benni Mack 1 day ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Gerrit Code Review 1 day ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59704

#8 Updated by Benni Mack 1 day ago

  • Status changed from Under Review to Resolved

Also available in: Atom PDF