Bug #87712

stdWrap.lang does not use Site Handling

Added by Benni Mack almost 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Link Handling, Site Handling & Routing
Target version:
Start date:
2019-02-14
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

If you do

10 = TEXT
10.value = English
10.lang.de = German

this does not work, as this still relies on ugly TypoScript settings.


Related issues

Related to TYPO3 Core - Bug #91721: stdWrap.lang does not support fallbacks of custom languagesResolved2020-06-28

Actions
#1

Updated by Gerrit Code Review almost 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59698

#2

Updated by Gerrit Code Review almost 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59698

#3

Updated by Gerrit Code Review almost 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59698

#4

Updated by Sven Juergens almost 3 years ago

Hi Benni,

your Patch ist not working with this example:

10 = TEXT
10.value = german
10.lang.en = english

In your patch you use
$currentLanguageCode = $siteLanguage->getTypo3Language();

but for "en" this code give back "default"

maybe you can use
"$siteLanguage->getTwoLetterIsoCode()"

?

Best Regards
Sven

#5

Updated by Benni Mack almost 3 years ago

hey Sven,

good question. Before, this TypoScript option was set to config.language = default (= loading XLF files with "default" language), so config.language = en was wrong actually as "en" never existed, so it "fell back" to default.

#6

Updated by Benni Mack almost 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#7

Updated by Gerrit Code Review almost 3 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59704

#8

Updated by Benni Mack almost 3 years ago

  • Status changed from Under Review to Resolved
#9

Updated by Benni Mack over 2 years ago

  • Status changed from Resolved to Closed
#10

Updated by Christoph Lehmann over 1 year ago

  • Related to Bug #91721: stdWrap.lang does not support fallbacks of custom languages added

Also available in: Atom PDF