Bug #87744: Unknown modifier 'r' - TYPO3 Core - TYPO3 Forge

Custom queries

Accessibility
Easy tasks
Forge Triage
JavaScript issues
JavaScript Issues (w/o Epics/Stories)
My open issues
No feedback within 90 days
Open Bugs
Open issues of 10
Recently modified
Regressions
Stabilization Issues
Usability or UX

Watchers (1)

Markus Klein

Actions

Copy link

Bug #87744

closed

Unknown modifier 'r'

Added by Remo H. almost 6 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

Must have

Assignee:

Category:

Frontend

Target version:

Start date:

2019-02-19

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

7.2

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

Redirect throws error in frontend (any page).

(1/1) #1476107295 TYPO3\CMS\Core\Error\Exception

PHP Warning: preg_match(): Unknown modifier 'r' in /var/www/web/typo3/sysext/redirects/Classes/Service/RedirectService.php line 82

at TYPO3\CMS\Core\Error\ErrorHandler->handleError(2, 'preg_match(): Unknown modifier \'r\'', '/var/www/web/typo3/sysext/redirects/Classes/Service/RedirectService.php', 82, array('r', 'S'))

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Markus Klein almost 6 years ago

Status changed from New to Needs Feedback

What does your redirect regex look like?
I assume that it contains a slash (followed by an "r"), which causes this issue.

Actions

Copy link

Updated by Remo H. over 5 years ago

Source Path: /fr/service/

The main issue is, that it is possible to break the whole frontend by adding a wrong regular expression.
This should not be possible. Not every editor knows about regular expressions...

The regular expression should be tested first.
Perhaps something like https://github.com/r3h6/TYPO3.EXT.error404page/blob/master/Classes/Utility/RegexUtility.php

Actions

Copy link

Updated by Markus Klein over 5 years ago

Status changed from Needs Feedback to Accepted
Priority changed from Should have to Must have

Yes we talked about that already. I tend to forbid entering a full regex here. So the slash delimiter is fixed then and anything entered in this field is escaped before being used in the regex. (preg_quote)
Problem is that this could be a breaking change for existing installations.

Actions

Copy link

Updated by Gerrit Code Review over 5 years ago

Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59817

Actions

Copy link

Updated by Gerrit Code Review over 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59817

Actions

Copy link

Updated by Gerrit Code Review over 5 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59817

Actions

Copy link

Updated by Gerrit Code Review over 5 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59817

Actions

Copy link

Updated by Gerrit Code Review over 5 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59817

Actions

Copy link

Updated by Gerrit Code Review over 5 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59817

Actions

Copy link

#10

Updated by Gerrit Code Review over 5 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59847

Actions

Copy link

#11